http3: add remote address to request context #4208
Conversation
Add the remote address of the underlying packet connection to the HTTP request context. This is useful for applications that need access to the actual remote address (wrapped in a net.Addr) rather than just its string representation. Fixes quic-go#4198
I was not sure how deep we want to go to assure the right value is set. For now, it asserts that a net.Addr is present in the context. Due to the dynamic nature of the requests, it is a bit harder to know exactly how the remote address will look like. IPv4 vs IPv6, random high port. I think it is fine to only assert that the value is present.
|
Done. I was not sure how deep we want to go to assure the right value is set. Due to the dynamic nature of the requests, it is a bit harder to know |
Makes sense, thank you! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4208 +/- ##
==========================================
- Coverage 83.75% 83.73% -0.02%
==========================================
Files 150 150
Lines 15470 15471 +1
==========================================
- Hits 12956 12954 -2
- Misses 2016 2019 +3
Partials 498 498 ☔ View full report in Codecov by Sentry. |
Add the remote address of the underlying packet connection to the HTTP request context. This is useful for applications that need access to the actual remote address (wrapped in a net.Addr) rather than just its string representation.
Fixes #4198