Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce calls to time.Now() calls in connection #4191

Merged
merged 1 commit into from
Dec 6, 2023
Merged

reduce calls to time.Now() calls in connection #4191

merged 1 commit into from
Dec 6, 2023

Conversation

birneee
Copy link
Contributor

@birneee birneee commented Dec 6, 2023

No description provided.

marten-seemann
marten-seemann approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (87ef8ec) 83.72% compared to head (ef1fee3) 83.72%.

Files Patch % Lines
connection.go 66.67% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4191      +/-   ##
==========================================
- Coverage   83.72%   83.72%   -0.00%     
==========================================
  Files         150      150              
  Lines       15434    15433       -1     
==========================================
- Hits        12922    12921       -1     
  Misses       2014     2014              
  Partials      498      498

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann changed the title fix #4190 reduce calls to time.Now() calls in connection Dec 6, 2023
@marten-seemann marten-seemann linked an issue Dec 6, 2023 that may be closed by this pull request
Reduce time.Now() calls in connection #4190
Closed
@marten-seemann marten-seemann merged commit 45922f7 into quic-go:master Dec 6, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce time.Now() calls in connection
2 participants
@birneee @marten-seemann