Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce time.Now() calls in connection #4190

Closed
birneee opened this issue Dec 6, 2023 · 2 comments · Fixed by #4191
Closed

Reduce time.Now() calls in connection #4190

birneee opened this issue Dec 6, 2023 · 2 comments · Fixed by #4191

Comments

@birneee
Copy link
Contributor

birneee commented Dec 6, 2023

In connection.go, triggerSending is calling time.Now even though it is already called earlier in triggerSending or runLoop.

And in maybeSendAckOnlyPacket, even though now is passed as an argument, it is called again in this function.
@marten-seemann
Copy link
Member

Would you mind opening a PR?

@birneee
Copy link
Contributor Author

birneee commented Dec 6, 2023

already in the works :)

birneee added a commit to birneee/quic-go that referenced this issue Dec 6, 2023
@birneee
fix quic-go#4190
ef1fee3
@marten-seemann marten-seemann linked a pull request Dec 6, 2023 that will close this issue
reduce calls to time.Now() calls in connection #4191
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reduce calls to time.Now() calls in connection birneee/quic-go
2 participants
@marten-seemann @birneee