Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't retire the conn ID that's in use when receiving a retransmission #2652

Merged
merged 1 commit into from
Jul 8, 2020
Merged

don't retire the conn ID that's in use when receiving a retransmission #2652

merged 1 commit into from
Jul 8, 2020

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Jul 6, 2020 •
edited
Loading

Fixes #2658.

@codecov
Copy link

codecov bot commented Jul 6, 2020 •
edited
Loading

Codecov Report

Merging #2652 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
+ Coverage   86.37%   86.39%   +0.02%     
==========================================
  Files         122      122              
  Lines        9757     9757              
==========================================
+ Hits         8427     8429       +2     
+ Misses        995      994       -1     
+ Partials      335      334       -1
Impacted Files Coverage Δ
conn_id_manager.go 94.17% <100.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4720e4...34f0c93. Read the comment docs.

@marten-seemann marten-seemann mentioned this pull request Jul 8, 2020
Closed
@marten-seemann marten-seemann merged commit 5227fef into master Jul 8, 2020
@marten-seemann marten-seemann deleted the fix-retiring-of-active-conn-id branch July 8, 2020 05:06
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
Closed
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-clemente lucas-clemente lucas-clemente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid retirement of connection ID when receiving a duplicate NCID frame for a CID that's in use
2 participants
@marten-seemann @lucas-clemente