Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid retirement of connection ID when receiving a duplicate NCID frame for a CID that's in use #2658

Closed
marten-seemann opened this issue Jul 8, 2020 · 0 comments · Fixed by #2652
Labels

Comments

@marten-seemann
Copy link
Member

When we receive a duplicate NEW_CONNECTION_ID for the the connection ID that's currently in use, we immediately send a RETIRE_CONNECTION_ID frame for that connection ID, without actually retiring it.

That means that this connection ID is retired in a packet that uses the same connection ID. This is a protocol violation. More importantly, since we never actually retire the connection ID, packets will end up getting dropped as soon as the peer drops the association between that connection ID and the session (which happens after 5 seconds in quic-go).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant