Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard: E8.5 TKL #9447

Merged
merged 21 commits into from
Jun 20, 2020
Merged

New Keyboard: E8.5 TKL #9447

merged 21 commits into from
Jun 20, 2020

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Jun 17, 2020 •
edited
Loading

Description

Adding in Exclusive's E8.5 Hotswap boards.

Please Note

  • This actually covers hotswap and soldered boards. I noticed that matrix was identical across all 3 so I encapsulated them under the same directory and just differentiated between the boards using different LAYOUT macros.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin
e85 commit
5ee7651
@mechmerlin
update exclusive directory readme
56e39e4
@mechmerlin
add both hotswap layouts to the h file as matrix is just about the sa…
73be3d2 
…me for both of them
@mechmerlin
fix up a few files
bbe5ac6
@mechmerlin
add a RESET key to Layer 1
a88f515
@mechmerlin
add a VIA enabled keymap
7ee0647
@mechmerlin
rather than disable more features, I figured it was more prudent to r…
aca815f 
…emove a layer as this is already considered a larger board. This was done in order to save on firmware space as the previous commit was exceeding it.
@mechmerlin
create a directory for tsangan for easier make targets
29658fd
@mechmerlin
this is not a tkl_ansi board, its got one more key
a0b1064
@mechmerlin
rename tkl_ansi to tkl_standard and add another keymap for it
514db3d
@mechmerlin
move everything up one level
4032eb5
@mechmerlin
rename hotswap to e85 and update readme for new paths
87c1ee6
@mechmerlin
rename layouts and add a LAYOUT_all to info.json
7f194e9
@mechmerlin
missed some renames
87db522
@mechmerlin
checking in all my code
b6da088
@mechmerlin
come up with a more sensible PID
7a77b33
@mechmerlin
update name on info.json
6545be2
@mechmerlin
make rgb lighting much simpler
03923b1
@drashna drashna requested a review from a team June 18, 2020 07:04
fauxpark
fauxpark requested changes Jun 19, 2020
View reviewed changes
keyboards/exclusive/e85/config.h Outdated Show resolved Hide resolved
keyboards/exclusive/e85/e85.c Outdated Show resolved Hide resolved
keyboards/exclusive/e85/rules.mk Outdated Show resolved Hide resolved
@Erovia Erovia merged commit de79d55 into qmk:master Jun 20, 2020
@mechmerlin mechmerlin mentioned this pull request Jun 24, 2020
Merged
6 tasks
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@mechmerlin @fauxpark @jakobaa
New Keyboard: E8.5 TKL (qmk#9447)
ff2e5d1 
Co-authored-by: Ryan <[email protected]>
@mechmerlin mechmerlin deleted the feature/e85_hotswap branch January 26, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@Erovia Erovia Erovia approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mechmerlin @drashna @Erovia @fauxpark