Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard: Wolfmark Club WM1 #9121

Merged
merged 29 commits into from
May 21, 2020
Merged

New Keyboard: Wolfmark Club WM1 #9121

merged 29 commits into from
May 21, 2020

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented May 17, 2020 •
edited
Loading

Description

With much help from @tzarc we finally have QMK working on this guy! Thanks to mrpetrov for lending me his board to get this done on.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes May 17, 2020
View reviewed changes
keyboards/wolfmarkclub/wm1/readme.md Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/readme.md Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/rules.mk Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/rules.mk Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/wm1.c Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/wm1.c Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/rules.mk Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/rules.mk Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/config.h Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team May 17, 2020 23:18
@tzarc tzarc self-requested a review May 18, 2020 00:40
tzarc
tzarc requested changes May 18, 2020
View reviewed changes
keyboards/wolfmarkclub/wm1/bootloader_defs.h Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/ld/wm1_f103.ld Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/rules.mk Outdated Show resolved Hide resolved
@tzarc tzarc requested a review from a team May 18, 2020 00:52
zvecr
zvecr requested changes May 18, 2020
View reviewed changes
keyboards/wolfmarkclub/wm1/config.h Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/rules.mk Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/rules.mk Outdated Show resolved Hide resolved
mechmerlin and others added 13 commits May 17, 2020 20:41
@mechmerlin @fauxpark
Update keyboards/wolfmarkclub/wm1/readme.md
1718d82 
Co-authored-by: Ryan <[email protected]>
@mechmerlin @fauxpark
Update keyboards/wolfmarkclub/wm1/rules.mk
392b4f1 
Co-authored-by: Ryan <[email protected]>
@mechmerlin @fauxpark
Update keyboards/wolfmarkclub/wm1/rules.mk
7f02897 
Co-authored-by: Ryan <[email protected]>
@mechmerlin @fauxpark
Update keyboards/wolfmarkclub/wm1/rules.mk
c2509b6 
Co-authored-by: Ryan <[email protected]>
@mechmerlin @fauxpark
Update keyboards/wolfmarkclub/wm1/rules.mk
6b1cf23 
Co-authored-by: Ryan <[email protected]>
@mechmerlin @fauxpark
Update keyboards/wolfmarkclub/wm1/config.h
b5da6a1 
Co-authored-by: Ryan <[email protected]>
@mechmerlin @tzarc
Update keyboards/wolfmarkclub/wm1/ld/wm1_f103.ld
26763dd 
Co-authored-by: Nick Brassel <[email protected]>
@mechmerlin @tzarc
Update keyboards/wolfmarkclub/wm1/bootloader_defs.h
222c166 
Co-authored-by: Nick Brassel <[email protected]>
@mechmerlin @zvecr
Update keyboards/wolfmarkclub/wm1/config.h
ae9c973 
Co-authored-by: Joel Challis <[email protected]>
@mechmerlin @zvecr
Update keyboards/wolfmarkclub/wm1/rules.mk
92773e9 
Co-authored-by: Joel Challis <[email protected]>
@mechmerlin @fauxpark
Update keyboards/wolfmarkclub/wm1/wm1.c
8ec58f2 
Co-authored-by: Ryan <[email protected]>
@mechmerlin @fauxpark
Update keyboards/wolfmarkclub/wm1/wm1.c
bc9cdde 
Co-authored-by: Ryan <[email protected]>
@mechmerlin @tzarc
Update keyboards/wolfmarkclub/wm1/rules.mk
cd59fdf 
Co-authored-by: Nick Brassel <[email protected]>
@yulei
Copy link
Contributor

yulei commented May 18, 2020

the original codes were here:)

https://github.com/yulei/qmk_firmware/blob/wm690/keyboards/wm1/v3/

The codes should be broken with the latest qmk, but the pin definitions could be an reference source.

@mechmerlin
Copy link
Contributor Author

the original codes were here:)

https://github.com/yulei/qmk_firmware/blob/wm690/keyboards/wm1/v3/

The codes should be broken with the latest qmk, but the pin definitions could be an reference source.

oof, this would have been super helpful lol

noroadsleft
noroadsleft requested changes May 19, 2020
View reviewed changes
keyboards/wolfmarkclub/wm1/readme.md Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/rules.mk Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/rules.mk Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/rules.mk Outdated Show resolved Hide resolved
keyboards/wolfmarkclub/wm1/rules.mk Outdated Show resolved Hide resolved
@tzarc tzarc requested review from drashna and a team May 21, 2020 01:54
noroadsleft
noroadsleft approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 9e40374 into qmk:master May 21, 2020
@noroadsleft
Copy link
Member

Thanks!

sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@mechmerlin @sowbug
[Keyboard] Wolfmark Club WM1 (qmk#9121)
9d46067 
* do the basic port for the WM1

* with much help from tzarc, get the addresses correct

* make the keymap more closely mirror what the board has

* Add QMK Configurator support

* update the readme

* get indicator leds working

* enable RGB underglow

* fix up rgb underglow

* add notes regarding existence of backlight

* Update keyboards/wolfmarkclub/wm1/readme.md

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/config.h

* Update keyboards/wolfmarkclub/wm1/ld/wm1_f103.ld

* Update keyboards/wolfmarkclub/wm1/bootloader_defs.h

* Update keyboards/wolfmarkclub/wm1/config.h

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/wm1.c

* Update keyboards/wolfmarkclub/wm1/wm1.c

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/readme.md

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* update readme
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@mechmerlin @turky
[Keyboard] Wolfmark Club WM1 (qmk#9121)
2f2dd35 
* do the basic port for the WM1

* with much help from tzarc, get the addresses correct

* make the keymap more closely mirror what the board has

* Add QMK Configurator support

* update the readme

* get indicator leds working

* enable RGB underglow

* fix up rgb underglow

* add notes regarding existence of backlight

* Update keyboards/wolfmarkclub/wm1/readme.md

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/config.h

* Update keyboards/wolfmarkclub/wm1/ld/wm1_f103.ld

* Update keyboards/wolfmarkclub/wm1/bootloader_defs.h

* Update keyboards/wolfmarkclub/wm1/config.h

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/wm1.c

* Update keyboards/wolfmarkclub/wm1/wm1.c

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/readme.md

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* update readme
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@mechmerlin @jakobaa
[Keyboard] Wolfmark Club WM1 (qmk#9121)
a355cf8 
* do the basic port for the WM1

* with much help from tzarc, get the addresses correct

* make the keymap more closely mirror what the board has

* Add QMK Configurator support

* update the readme

* get indicator leds working

* enable RGB underglow

* fix up rgb underglow

* add notes regarding existence of backlight

* Update keyboards/wolfmarkclub/wm1/readme.md

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/config.h

* Update keyboards/wolfmarkclub/wm1/ld/wm1_f103.ld

* Update keyboards/wolfmarkclub/wm1/bootloader_defs.h

* Update keyboards/wolfmarkclub/wm1/config.h

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/wm1.c

* Update keyboards/wolfmarkclub/wm1/wm1.c

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/readme.md

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* update readme
@mechmerlin mechmerlin deleted the feature/wolfmark_wm1 branch January 26, 2021 15:00
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@mechmerlin @sjmacneil
[Keyboard] Wolfmark Club WM1 (qmk#9121)
5d88910 
* do the basic port for the WM1

* with much help from tzarc, get the addresses correct

* make the keymap more closely mirror what the board has

* Add QMK Configurator support

* update the readme

* get indicator leds working

* enable RGB underglow

* fix up rgb underglow

* add notes regarding existence of backlight

* Update keyboards/wolfmarkclub/wm1/readme.md

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/config.h

* Update keyboards/wolfmarkclub/wm1/ld/wm1_f103.ld

* Update keyboards/wolfmarkclub/wm1/bootloader_defs.h

* Update keyboards/wolfmarkclub/wm1/config.h

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/wm1.c

* Update keyboards/wolfmarkclub/wm1/wm1.c

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/readme.md

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* Update keyboards/wolfmarkclub/wm1/rules.mk

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@zvecr zvecr zvecr requested changes

@tzarc tzarc tzarc approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mechmerlin @yulei @noroadsleft @drashna @tzarc @fauxpark @zvecr