Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyboard] Add kudox rev3 #8704

Merged
merged 5 commits into from
Apr 15, 2020
Merged

[keyboard] Add kudox rev3 #8704

merged 5 commits into from
Apr 15, 2020

Conversation

x1-
Copy link
Contributor

@x1- x1- commented Apr 6, 2020

Description

Add keyboards/kudox rev3.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Nothing

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team April 12, 2020 18:30
noroadsleft
noroadsleft requested changes Apr 13, 2020
View reviewed changes
keyboards/kudox/readme.md Outdated Show resolved Hide resolved
keyboards/kudox/rev3/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/kudox/rev3/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/kudox/rev3/keymaps/jis/config.h Outdated Show resolved Hide resolved
keyboards/kudox/rev3/keymaps/jis/readme.md Outdated Show resolved Hide resolved
@x1-
Copy link
Contributor Author

x1- commented Apr 14, 2020

@noroadsleft Thank you for reviewing 🙇❗
I modified the codes you pointed.

@noroadsleft noroadsleft merged commit c0b99ba into qmk:master Apr 15, 2020
@noroadsleft
Copy link
Member

Thanks!

Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
@x1- @Quarren42
[keyboard] Add kudox rev3 (qmk#8704)
9719453 
* Add kudox rev3.

* Add default keymap for Kudox rev3.

* Add JIS keymap for Kudox rev3.

* Modified default revision of kudox rev3.

* Modified unnecessary codes.
galactic1969 added a commit to galactic1969/qmk_firmware that referenced this pull request Apr 16, 2020
@galactic1969
Merge remote-tracking branch 'upstream/master'
6a9d5c0 
* upstream/master: (1967 commits)
  [Docs] Japanese translation of docs/feature_combo.md (qmk#8671)
  Remove old setup scripts (qmk#8811)
  [Keyboard] ProjectKB Alice rev2 (qmk#8718)
  MILC: Fix setting config values for store_true and store_false (qmk#8813)
  KC60 Refactor (qmk#8782)
  Fix quick7 build command (qmk#8812)
  Miscellaneous stuff: remove clang-complete and autocomplete.sh, fix some rules.mk comments (qmk#8784)
  [Keyboard] add new keyboard quick7 (qmk#8670)
  [Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752)
  [keyboard] Add kudox rev3 (qmk#8704)
  CLI: Fix doctor error when can't run `bin/qmk --version`. (qmk#8796)
  deleted unused keymap (qmk#8797)
  Add missing repository name to qmk setup w/ github (qmk#8792)
  Configure RGBLIGHT_SPLIT for Mint60 (qmk#8788)
  [Keyboard] Aplx6 (qmk#8727)
  update pvinis keymap (qmk#8746)
  CLI: Use `shutil.which` to detect gmake, instead of OS check.
  CLI: Invoke gmake on FreeBSD when using `qmk compile`.
  [Docs] Japanese translation of docs/feature_dip_switch.md (qmk#8673)
  Fix broken KBD8X MKII Hardware link (qmk#8787)
  ...
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@x1- @kujawakk
[keyboard] Add kudox rev3 (qmk#8704)
99752aa 
* Add kudox rev3.

* Add default keymap for Kudox rev3.

* Add JIS keymap for Kudox rev3.

* Modified default revision of kudox rev3.

* Modified unnecessary codes.
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request May 3, 2020
@x1- @mrlinuxfish
[keyboard] Add kudox rev3 (qmk#8704)
86a229f 
* Add kudox rev3.

* Add default keymap for Kudox rev3.

* Add JIS keymap for Kudox rev3.

* Modified default revision of kudox rev3.

* Modified unnecessary codes.
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@x1- @lorenzoernesto
[keyboard] Add kudox rev3 (qmk#8704)
d5e906f 
* Add kudox rev3.

* Add default keymap for Kudox rev3.

* Add JIS keymap for Kudox rev3.

* Modified default revision of kudox rev3.

* Modified unnecessary codes.
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@x1- @sowbug
[keyboard] Add kudox rev3 (qmk#8704)
3e615f9 
* Add kudox rev3.

* Add default keymap for Kudox rev3.

* Add JIS keymap for Kudox rev3.

* Modified default revision of kudox rev3.

* Modified unnecessary codes.
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@x1- @turky
[keyboard] Add kudox rev3 (qmk#8704)
d58de7f 
* Add kudox rev3.

* Add default keymap for Kudox rev3.

* Add JIS keymap for Kudox rev3.

* Modified default revision of kudox rev3.

* Modified unnecessary codes.
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@x1- @jakobaa
[keyboard] Add kudox rev3 (qmk#8704)
f386b52 
* Add kudox rev3.

* Add default keymap for Kudox rev3.

* Add JIS keymap for Kudox rev3.

* Modified default revision of kudox rev3.

* Modified unnecessary codes.
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@x1- @sjmacneil
[keyboard] Add kudox rev3 (qmk#8704)
b0d3ca1 
* Add kudox rev3.

* Add default keymap for Kudox rev3.

* Add JIS keymap for Kudox rev3.

* Modified default revision of kudox rev3.

* Modified unnecessary codes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@x1- @noroadsleft @drashna @fauxpark