Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new keyboard quick7 #8670

Merged
merged 15 commits into from
Apr 15, 2020
Merged

add new keyboard quick7 #8670

merged 15 commits into from
Apr 15, 2020

Conversation

MakotoKurauchi
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei mtei requested a review from a team April 4, 2020 06:53
@mtei mtei added the keyboard label Apr 4, 2020
noroadsleft
noroadsleft requested changes Apr 5, 2020
View reviewed changes
keyboards/yushakobo/quick7/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/yushakobo/quick7/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/yushakobo/quick7/quick7.c Outdated Show resolved Hide resolved
keyboards/yushakobo/quick7/readme.md Outdated Show resolved Hide resolved
keyboards/yushakobo/quick7/rules.mk Outdated Show resolved Hide resolved
keyboards/yushakobo/quick7/rules.mk Outdated Show resolved Hide resolved
keyboards/yushakobo/quick7/rules.mk Outdated Show resolved Hide resolved
@noroadsleft noroadsleft requested a review from a team April 5, 2020 05:07
drashna
drashna requested changes Apr 5, 2020
View reviewed changes
keyboards/yushakobo/quick7/config.h Outdated Show resolved Hide resolved
mtei added a commit to mtei/qmk_firmware that referenced this pull request Apr 5, 2020
@mtei
update quantum/template/avr/config.h
84f23ae 
Modify the template of config.h according to drashna's recommendation. And I think the RGBLIGHT_ANIMATIONS is only for backwards compatibility. I think its use should be deprecated. So I removed it.

see qmk#8670 (comment)
@mtei mtei mentioned this pull request Apr 5, 2020
Closed
13 tasks
MakotoKurauchi and others added 10 commits April 12, 2020 09:59
@MakotoKurauchi @noroadsleft
Update keyboards/yushakobo/quick7/keymaps/default/keymap.c
d5d4574 
Co-Authored-By: James Young <[email protected]>
@MakotoKurauchi @noroadsleft
Update keyboards/yushakobo/quick7/quick7.c
57459fe 
Co-Authored-By: James Young <[email protected]>
@MakotoKurauchi @noroadsleft
Update keyboards/yushakobo/quick7/rules.mk
87b5cd9 
Co-Authored-By: James Young <[email protected]>
@MakotoKurauchi @fauxpark
Update keyboards/yushakobo/quick7/keymaps/default/keymap.c
2997a7a 
Co-Authored-By: Ryan <[email protected]>
@MakotoKurauchi @noroadsleft
Update keyboards/yushakobo/quick7/readme.md
9c0be2f 
Co-Authored-By: James Young <[email protected]>
@MakotoKurauchi @noroadsleft
Update keyboards/yushakobo/quick7/rules.mk
c9df5d8 
Co-Authored-By: James Young <[email protected]>
@MakotoKurauchi @noroadsleft
Update keyboards/yushakobo/quick7/rules.mk
625432b 
Co-Authored-By: James Young <[email protected]>
@MakotoKurauchi
Deleted unnecessary file.
ba396d2
@MakotoKurauchi
Comment added.
0f6acc4
@MakotoKurauchi @drashna
Update keyboards/yushakobo/quick7/config.h
2c762c9 
Co-Authored-By: Drashna Jaelre <[email protected]>
noroadsleft
noroadsleft requested changes Apr 12, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one thing from me, everything else looks good.

keyboards/yushakobo/quick7/readme.md Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from noroadsleft April 12, 2020 23:11
@noroadsleft noroadsleft merged commit 2ae39cc into qmk:master Apr 15, 2020
@noroadsleft
Copy link
Member

Thanks!

Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
@MakotoKurauchi @Quarren42
[Keyboard] add new keyboard quick7 (qmk#8670)
81e0112 
* add new keyboard quick7

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/quick7.c

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/rules.mk

* Deleted unnecessary file.

* Comment added.

* Update keyboards/yushakobo/quick7/config.h

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/config.h
galactic1969 added a commit to galactic1969/qmk_firmware that referenced this pull request Apr 16, 2020
@galactic1969
Merge remote-tracking branch 'upstream/master'
6a9d5c0 
* upstream/master: (1967 commits)
  [Docs] Japanese translation of docs/feature_combo.md (qmk#8671)
  Remove old setup scripts (qmk#8811)
  [Keyboard] ProjectKB Alice rev2 (qmk#8718)
  MILC: Fix setting config values for store_true and store_false (qmk#8813)
  KC60 Refactor (qmk#8782)
  Fix quick7 build command (qmk#8812)
  Miscellaneous stuff: remove clang-complete and autocomplete.sh, fix some rules.mk comments (qmk#8784)
  [Keyboard] add new keyboard quick7 (qmk#8670)
  [Keymap] Added custom layout for KBDFans KBD67 rev2 (qmk#8752)
  [keyboard] Add kudox rev3 (qmk#8704)
  CLI: Fix doctor error when can't run `bin/qmk --version`. (qmk#8796)
  deleted unused keymap (qmk#8797)
  Add missing repository name to qmk setup w/ github (qmk#8792)
  Configure RGBLIGHT_SPLIT for Mint60 (qmk#8788)
  [Keyboard] Aplx6 (qmk#8727)
  update pvinis keymap (qmk#8746)
  CLI: Use `shutil.which` to detect gmake, instead of OS check.
  CLI: Invoke gmake on FreeBSD when using `qmk compile`.
  [Docs] Japanese translation of docs/feature_dip_switch.md (qmk#8673)
  Fix broken KBD8X MKII Hardware link (qmk#8787)
  ...
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@MakotoKurauchi @kujawakk
[Keyboard] add new keyboard quick7 (qmk#8670)
9ccaad0 
* add new keyboard quick7

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/quick7.c

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/rules.mk

* Deleted unnecessary file.

* Comment added.

* Update keyboards/yushakobo/quick7/config.h

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/config.h
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request May 3, 2020
@MakotoKurauchi @mrlinuxfish
[Keyboard] add new keyboard quick7 (qmk#8670)
07f3a84 
* add new keyboard quick7

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/quick7.c

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/rules.mk

* Deleted unnecessary file.

* Comment added.

* Update keyboards/yushakobo/quick7/config.h

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/config.h
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@MakotoKurauchi @lorenzoernesto
[Keyboard] add new keyboard quick7 (qmk#8670)
0c01b2f 
* add new keyboard quick7

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/quick7.c

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/rules.mk

* Deleted unnecessary file.

* Comment added.

* Update keyboards/yushakobo/quick7/config.h

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/config.h
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@MakotoKurauchi @sowbug
[Keyboard] add new keyboard quick7 (qmk#8670)
55212ea 
* add new keyboard quick7

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/quick7.c

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/rules.mk

* Deleted unnecessary file.

* Comment added.

* Update keyboards/yushakobo/quick7/config.h

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/config.h
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@MakotoKurauchi @turky
[Keyboard] add new keyboard quick7 (qmk#8670)
3dbc4b7 
* add new keyboard quick7

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/quick7.c

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/rules.mk

* Deleted unnecessary file.

* Comment added.

* Update keyboards/yushakobo/quick7/config.h

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/config.h
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@MakotoKurauchi @jakobaa
[Keyboard] add new keyboard quick7 (qmk#8670)
cbf243e 
* add new keyboard quick7

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/quick7.c

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/rules.mk

* Deleted unnecessary file.

* Comment added.

* Update keyboards/yushakobo/quick7/config.h

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/config.h
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@MakotoKurauchi @sjmacneil
[Keyboard] add new keyboard quick7 (qmk#8670)
c181a1a 
* add new keyboard quick7

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/quick7.c

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/rules.mk

* Update keyboards/yushakobo/quick7/rules.mk

* Deleted unnecessary file.

* Comment added.

* Update keyboards/yushakobo/quick7/config.h

* Update keyboards/yushakobo/quick7/readme.md

* Update keyboards/yushakobo/quick7/keymaps/default/keymap.c

* Update keyboards/yushakobo/quick7/config.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtei mtei mtei approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MakotoKurauchi @noroadsleft @mtei @drashna @fauxpark @keyaki-namiki