Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Keyboard: KPRepublic BM60 RGB #7842

Merged
merged 8 commits into from
Jan 12, 2020
Merged

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Jan 9, 2020

Description

This is another port into QMK firmware from kbfirmware.com. This is a 60% with per key RGB leds. Customer who asked me to do this tested it and confirmed it working as I don't have an actual unit.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since KPRepublic seems to call this just "BM60 RGB," I'd prefer if the folder was bm60rgb instead of including the hs too.

keyboards/bm60hsrgb/config.h Outdated Show resolved Hide resolved
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mechmerlin
Copy link
Contributor Author

I've renamed the directory and associated files to bm60rgb.

@noroadsleft
Copy link
Member

Do we want to put this in a kprepublic vendor folder, ahead of #5206?

@mechmerlin
Copy link
Contributor Author

ooof that's an old PR. I think we should just merge this in for the time being. That PR has merge conflicts, so it can be moved as part of the merge conflict resolution.

@noroadsleft noroadsleft merged commit b6917c7 into qmk:master Jan 12, 2020
@noroadsleft
Copy link
Member

Thanks!

nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jan 12, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (71 commits)
  [Keyboard] Reviung41: Configurator layout support (qmk#7852)
  [Keyboard] IDB 60: Configurator bugfix (qmk#7851)
  [Keyboard] Add Xiaomi MK02 (qmk#7825)
  Add user keymaps for KBD67MKII/Lily58 (qmk#7671)
  [Keyboard] KPRepublic BM60 RGB (qmk#7842)
  Add Lily58 serial to LIB_SRC to avoid LTO issue (qmk#7868)
  Adi's DZ65RGB layout (qmk#7845)
  yapf and style
  Make the udev rules easier to read and manage
  Fix Pro Micro's and its bootloader's name
  CLI: Rework ModemManager check and add udev check
  [Keyboard] NK65 Refactor (qmk#7862)
  [Keymap] Updated keymaps (qmk#7834)
  [Keymap] Add additional dynamic macro key to dshields keymaps. (qmk#7853)
  added ymdk ymd09 keyboard (qmk#7831)
  [Keymap] Update my iris keymap for LTO and rgbled split (qmk#7849)
  [Keyboard] Changes to support latest release of VIA, moved files to "idb" folder in "keymaps" in preparation of adding more boards, made changes to LAYOUT_ macros (qmk#7798)
  Fix a couple of USB VIDs for the API (qmk#7848)
  Add per-key IGNORE_MOD_TAP_INTERRUPT feature (qmk#7838)
  Refactor f103,f072,f042 based keyboards to use new MCU selection defaults (qmk#7705)
  ...
@mechmerlin mechmerlin deleted the feature/bm60 branch February 5, 2020 16:18
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* initial commit from script

* edit all generated files with my name and some basic notes

* implement RGB Matrix support

* cleanups, file removals, and readme edits

* Update keyboards/bm60hsrgb/config.h

* rename to bm60rgb

* update included library and info.json keyboard name

* Update keyboards/bm60rgb/keymaps/default/readme.md
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* initial commit from script

* edit all generated files with my name and some basic notes

* implement RGB Matrix support

* cleanups, file removals, and readme edits

* Update keyboards/bm60hsrgb/config.h

* rename to bm60rgb

* update included library and info.json keyboard name

* Update keyboards/bm60rgb/keymaps/default/readme.md
@ADDUB2
Copy link

ADDUB2 commented Apr 25, 2020

I'm having some issues with this pcb the underglow got turned off the moment I flashed it and all the commands for lighting I flashed onto it don't work.

@daniarnaizg
Copy link

Underglow doesn't work. You cannot control it once you have flashed it.

@jrodan
Copy link

jrodan commented Sep 17, 2020

any idea how to fix it?
is that a problem with the pcb itself that you can not control underglow by itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants