Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor f103,f072,f042 based keyboards to use new MCU selection defaults #7705

Merged
merged 3 commits into from
Jan 10, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 23, 2019

Description

Types of Changes

The mapleleaf/stm32duino stuff needs another pass, as bootloader.mk gets loaded too early.

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label Dec 23, 2019
@zvecr zvecr changed the title Refactor f103,f072,f042 to use new MCU selection functionality Refactor f103,f072,f042 based keyboards to use new MCU selection defaults Dec 24, 2019
@drashna drashna requested a review from a team December 25, 2019 04:34
@zvecr zvecr marked this pull request as ready for review December 28, 2019 19:20
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zvecr sounds like the maple needs #2046 or something like it.

Otherwise, LGTM.

@drashna
Copy link
Member

drashna commented Jan 2, 2020

Did we want to merge this now, or wait for a fix for the maple stuff (ideally)

@zvecr
Copy link
Member Author

zvecr commented Jan 2, 2020

mapleleaf/stm32duino stuff has a few extra moving parts which need some work, like providing a common linker script. Its on my list but as this is an isolated enough iteration, it gets us a few steps closer to the end goal. The "fix" is more removing further duplication, and making bluepill usage even easier.

@zvecr zvecr force-pushed the feature/stm_rules_refactor branch from 8e1adae to 0d30bf5 Compare January 4, 2020 03:40
@zvecr zvecr force-pushed the feature/stm_rules_refactor branch from 0d30bf5 to 1d5bb9d Compare January 4, 2020 03:47
@zvecr zvecr merged commit e34af63 into qmk:master Jan 10, 2020
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jan 12, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (71 commits)
  [Keyboard] Reviung41: Configurator layout support (qmk#7852)
  [Keyboard] IDB 60: Configurator bugfix (qmk#7851)
  [Keyboard] Add Xiaomi MK02 (qmk#7825)
  Add user keymaps for KBD67MKII/Lily58 (qmk#7671)
  [Keyboard] KPRepublic BM60 RGB (qmk#7842)
  Add Lily58 serial to LIB_SRC to avoid LTO issue (qmk#7868)
  Adi's DZ65RGB layout (qmk#7845)
  yapf and style
  Make the udev rules easier to read and manage
  Fix Pro Micro's and its bootloader's name
  CLI: Rework ModemManager check and add udev check
  [Keyboard] NK65 Refactor (qmk#7862)
  [Keymap] Updated keymaps (qmk#7834)
  [Keymap] Add additional dynamic macro key to dshields keymaps. (qmk#7853)
  added ymdk ymd09 keyboard (qmk#7831)
  [Keymap] Update my iris keymap for LTO and rgbled split (qmk#7849)
  [Keyboard] Changes to support latest release of VIA, moved files to "idb" folder in "keymaps" in preparation of adding more boards, made changes to LAYOUT_ macros (qmk#7798)
  Fix a couple of USB VIDs for the API (qmk#7848)
  Add per-key IGNORE_MOD_TAP_INTERRUPT feature (qmk#7838)
  Refactor f103,f072,f042 based keyboards to use new MCU selection defaults (qmk#7705)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
…ults (qmk#7705)

* refactor keyboards using ST_STM32F072B_DISCOVERY to use 'MCU = STM32F072'

* refactor keyboards using GENERIC_STM32_F042X6 to use 'MCU = STM32F042'

* refactor keyboards using GENERIC_STM32_F103 to use 'MCU = STM32F103'
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
…ults (qmk#7705)

* refactor keyboards using ST_STM32F072B_DISCOVERY to use 'MCU = STM32F072'

* refactor keyboards using GENERIC_STM32_F042X6 to use 'MCU = STM32F042'

* refactor keyboards using GENERIC_STM32_F103 to use 'MCU = STM32F103'
@zvecr zvecr deleted the feature/stm_rules_refactor branch April 28, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants