Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rules.mk defaults for f103,f072,f042 #7704

Merged
merged 6 commits into from
Dec 28, 2019
Merged

Add rules.mk defaults for f103,f072,f042 #7704

merged 6 commits into from
Dec 28, 2019

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 23, 2019

Description

As an attempt to resurrect parts of #5669, this PR aims to add defaults for a few of the more popular STM32 chips.

2nd pass will be to refactor boards to use these new defaults where possible

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team December 23, 2019 22:45
@zvecr zvecr mentioned this pull request Dec 23, 2019
Merged
13 tasks
fauxpark
fauxpark requested changes Dec 24, 2019
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how these could ever need overriding, given they're kind of intrinsic properties of the MCU

quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
quantum/mcu_selection.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from fauxpark December 24, 2019 11:33
drashna
drashna reviewed Dec 25, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're touching it here, anyways ... would it be too much to ask to switch the order of the PID and VID for the DFU_SUFFIX_ARGS? That way, it's ... easier to read, and consistent with the DFU_ARGS?

Aside from that, I like it. It makes things a lot easier.

@zvecr zvecr requested a review from drashna December 25, 2019 21:15
@zvecr
Copy link
Member Author

zvecr commented Dec 25, 2019

Seems like a good opportunity to align more stuff! Done in 0064336.

noroadsleft
noroadsleft approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zvecr zvecr merged commit 250a99f into qmk:master Dec 28, 2019
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@zvecr @patrl
Add rules.mk defaults for f103,f072,f042 (qmk#7704)
bdb793c 
* Add rules.mk defaults for f103,f072,f042

* Add rules.mk defaults for f103,f072,f042 - remove comment

* Add rules.mk defaults for f103,f072,f042 - align USE_FPU

* Reset MCU to avoid build issues

* Move essential config values to top and remove ability for override

* Align DFU_SUFFIX_ARGS order with DFU_ARGS
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 2, 2020
@zvecr @drashna
Add rules.mk defaults for f103,f072,f042 (qmk#7704)
12707a7 
* Add rules.mk defaults for f103,f072,f042

* Add rules.mk defaults for f103,f072,f042 - remove comment

* Add rules.mk defaults for f103,f072,f042 - align USE_FPU

* Reset MCU to avoid build issues

* Move essential config values to top and remove ability for override

* Align DFU_SUFFIX_ARGS order with DFU_ARGS
fdidron added a commit to zsa/qmk_firmware that referenced this pull request Jan 6, 2020
@drashna @zvecr @fdidron
Add rules.mk defaults for f103,f072,f042 (qmk#7704) (#242)
9b428bb 
* Add rules.mk defaults for f103,f072,f042

* Add rules.mk defaults for f103,f072,f042 - remove comment

* Add rules.mk defaults for f103,f072,f042 - align USE_FPU

* Reset MCU to avoid build issues

* Move essential config values to top and remove ability for override

* Align DFU_SUFFIX_ARGS order with DFU_ARGS

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Florian Didron <[email protected]>
fdidron added a commit to zsa/qmk_firmware that referenced this pull request Jan 8, 2020
@drashna @zvecr @fdidron
Add rules.mk defaults for f103,f072,f042 (qmk#7704) (#242)
138f981 
* Add rules.mk defaults for f103,f072,f042

* Add rules.mk defaults for f103,f072,f042 - remove comment

* Add rules.mk defaults for f103,f072,f042 - align USE_FPU

* Reset MCU to avoid build issues

* Move essential config values to top and remove ability for override

* Align DFU_SUFFIX_ARGS order with DFU_ARGS

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Florian Didron <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@zvecr @HokieGeek
Add rules.mk defaults for f103,f072,f042 (qmk#7704)
5df11ca 
* Add rules.mk defaults for f103,f072,f042

* Add rules.mk defaults for f103,f072,f042 - remove comment

* Add rules.mk defaults for f103,f072,f042 - align USE_FPU

* Reset MCU to avoid build issues

* Move essential config values to top and remove ability for override

* Align DFU_SUFFIX_ARGS order with DFU_ARGS
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@zvecr @kujawakk
Add rules.mk defaults for f103,f072,f042 (qmk#7704)
7b338f0 
* Add rules.mk defaults for f103,f072,f042

* Add rules.mk defaults for f103,f072,f042 - remove comment

* Add rules.mk defaults for f103,f072,f042 - align USE_FPU

* Reset MCU to avoid build issues

* Move essential config values to top and remove ability for override

* Align DFU_SUFFIX_ARGS order with DFU_ARGS
@zvecr zvecr deleted the feature/stm_rules_defaults branch April 28, 2020 01:05
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Add rules.mk defaults for f103,f072,f042 (qmk#7704)
b20923a 
* Add rules.mk defaults for f103,f072,f042

* Add rules.mk defaults for f103,f072,f042 - remove comment

* Add rules.mk defaults for f103,f072,f042 - align USE_FPU

* Reset MCU to avoid build issues

* Move essential config values to top and remove ability for override

* Align DFU_SUFFIX_ARGS order with DFU_ARGS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @fauxpark @noroadsleft