Move Ergodox EZ RGB Light code to custom driver #7309
Conversation
drashna
force-pushed
the
keyboard/ergodox_ez_custom
branch
from
13b5eed
to
ea6a7a5
Compare
Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]>
drashna
force-pushed
the
keyboard/ergodox_ez_custom
branch
from
ea6a7a5
to
b0d11d2
Compare
|
So, re-reading this: The ergodox EZ has other code talking over i2c also, but it looks like this part is just directly bitbanging the i2c hardware. How does that interact with the i2c code? I suppose it appears to work, so it must not be all THAT bad, but it feels sorta ugly. |
|
@seebs I'm not exactly sure what you mean there. But all this code has already existed and is what is actively being used. It was more of a matter of "where", as all the I2C code for the LEDs was actually in core files, and ONLY the ergodox EZ was using it. Also, this has some additional work needed, to make things cleaner, especially as I did mean to open this as a draft... |
|
I'm ... actually now very confused and no longer sure what I'm talking about. So far as I know, the EZ has only one I2C bus, the four-wire cable running from the (AVR) right hand to the (MCP23018) left hand. Most of the EZ code uses i2c_master.h/i2c_master.c to drive these, using functions with names like The i2c code that was in ws_2812, and is now in the ergodox directory, is bit-banging pins on PORTD. As it happens, those are the same pins used by the i2c hardware in the chip; PD0 == SCL, PD1 == SDA. This isn't a criticism of the move, which obviously doesn't change it, but I'm not sure how this interacts with any other use of these pins from code that isn't the ws2812 driving code, since the chip has built-in hardware that can use these pins, and as I understand it, can use them asynchronously from other code running on the chip. |
I ... 100% understand this, and I've been there more times than I can count!
Correct.
I can't say that I'm expert here, but .... the code added has been what has been used by the ergodox EZ for quite some time now. The only difference now, is that it's in the ergodox EZ's folder, rather than in the core driver for ws2812. It's functionally identical, with the only change being "where" the code is located. And you're probably correct, the code could be cleaned up and handled with the standard functions. However, I'll have to see about wrapping my head around that, and testing it. Something that tends to be more challenging for me. But ... I've been expanding my skills, so .... |
|
This should be a much cleaner implementation, and affect a minimal number of core files. |
* 'master' of https://github.com/qmk/qmk_firmware: (475 commits) [Keyboard] kbdfans keyboards NKRO enable (qmk#7364) [Keyboard] fix DZ60RGB info.json (qmk#7362) Adding new pcb with default keymap and personal keymap (qmk#7314) [Core] Cleanup rules.mk for F303 keyboards (qmk#7306) [Docs] Japanese translation of docs/ja/newbs_best_practices.md (qmk#7337) Set device version from config.h for V-USB boards (qmk#7316) Add support for configurable polling interval and power usage o… (qmk#7336) capslock_led (qmk#7359) Move Ergodox EZ RGB Light code to custom driver (qmk#7309) Fix shell.nix by pinning nixpkgs (qmk#6213) [Keyboard] add kbdmini; dztech, kbdfans keyboards cleanup (qmk#7223) [Docs] Encourage newbs to not download the repo as a zip (qmk#7353) Update debounce docs (qmk#7355) [Keyboard] Add TG4x (qmk#7351) [Keyboard] Add FLX Virgo (qmk#7352) format code according to conventions [skip ci] Adding verd layout to RSII (qmk#7296) Add my custom layouts for GH60, DZ60 and Minivan (qmk#7278) [Keyboard] Added abnt2 layout to dz60 (qmk#7340) [Keyboard] add Little Keyboards as a seller of helix pcbs outside of japan (qmk#7249) ...
* Move Ergodox EZ RGB code to custom driver Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]> * Make Clipping range accessible for custom drivers * Remove RGBW_BB_TWI from driver and docs * Revert changes to clipping range support * Use just rgblight_set instead of full custom driver * Convert to i2c_master commands * Rename rgblight driver and clean up includes
* Move Ergodox EZ RGB code to custom driver Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]> * Make Clipping range accessible for custom drivers * Remove RGBW_BB_TWI from driver and docs * Revert changes to clipping range support * Use just rgblight_set instead of full custom driver * Convert to i2c_master commands * Rename rgblight driver and clean up includes
* Move Ergodox EZ RGB code to custom driver Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]> * Make Clipping range accessible for custom drivers * Remove RGBW_BB_TWI from driver and docs * Revert changes to clipping range support * Use just rgblight_set instead of full custom driver * Convert to i2c_master commands * Rename rgblight driver and clean up includes
* Move Ergodox EZ RGB code to custom driver Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]> * Make Clipping range accessible for custom drivers * Remove RGBW_BB_TWI from driver and docs * Revert changes to clipping range support * Use just rgblight_set instead of full custom driver * Convert to i2c_master commands * Rename rgblight driver and clean up includes
* Move Ergodox EZ RGB code to custom driver Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]> * Make Clipping range accessible for custom drivers * Remove RGBW_BB_TWI from driver and docs * Revert changes to clipping range support * Use just rgblight_set instead of full custom driver * Convert to i2c_master commands * Rename rgblight driver and clean up includes
* ARM - ws2812 bitbang (qmk#7173) * Initial ARM bitbang ws2812 driver * Unify chibios platform to run rgblight_task * Remove 'avr only' comments from ws2812 docs * Remove 'avr only' comments from ws2812 docs * Unify chibios platform to run rgblight_task - review comments * Remove debug flags from keymap * Add comments from review * Add defines for STM32L0XX * Attempt to get arm ws2812 working on multiple gcc versions * Support RGBLIGHT_SLEEP when ChibiOS boards suspend (qmk#7280) Copypasta from the AVR suspend implementation with a Teensy-specific hack removed * Unify RGB and RGBW commands (qmk#7297) * Fix unicode in comments Co-Authored-By: fauxpark <[email protected]> * Remove separate RGBW implementation for a unified function * Set White to 0 in RGBW LEDs This is just to get this working, later, proper brightness can be handled elsewhere. * Use us instead of nanoseconds(?) since it renders correctly on web * Remove RGBW function from arm/ws2812.h * Remove RGBW function from arm/ws2812.c * Formatting changes * Add doc info * Remove force of debug on within rgblight - causes lockups waiting for hid_listen (qmk#7330) * Move Ergodox EZ RGB Light code to custom driver (qmk#7309) * Move Ergodox EZ RGB code to custom driver Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]> * Make Clipping range accessible for custom drivers * Remove RGBW_BB_TWI from driver and docs * Revert changes to clipping range support * Use just rgblight_set instead of full custom driver * Convert to i2c_master commands * Rename rgblight driver and clean up includes * Use White channel on RGBW LEDs * SPI DMA based RGB Underglow for STM32 (qmk#7674) * Initial stash of ws2812 spi driver * Update comment, add sync backup plan * Add testing notes to spi ws2812 driver * Align RGBW error messages Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Jonathan Rascher <[email protected]> Co-authored-by: Florian Didron <[email protected]>
* ARM - ws2812 bitbang (qmk#7173) * Initial ARM bitbang ws2812 driver * Unify chibios platform to run rgblight_task * Remove 'avr only' comments from ws2812 docs * Remove 'avr only' comments from ws2812 docs * Unify chibios platform to run rgblight_task - review comments * Remove debug flags from keymap * Add comments from review * Add defines for STM32L0XX * Attempt to get arm ws2812 working on multiple gcc versions * Support RGBLIGHT_SLEEP when ChibiOS boards suspend (qmk#7280) Copypasta from the AVR suspend implementation with a Teensy-specific hack removed * Unify RGB and RGBW commands (qmk#7297) * Fix unicode in comments Co-Authored-By: fauxpark <[email protected]> * Remove separate RGBW implementation for a unified function * Set White to 0 in RGBW LEDs This is just to get this working, later, proper brightness can be handled elsewhere. * Use us instead of nanoseconds(?) since it renders correctly on web * Remove RGBW function from arm/ws2812.h * Remove RGBW function from arm/ws2812.c * Formatting changes * Add doc info * Remove force of debug on within rgblight - causes lockups waiting for hid_listen (qmk#7330) * Move Ergodox EZ RGB Light code to custom driver (qmk#7309) * Move Ergodox EZ RGB code to custom driver Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]> * Make Clipping range accessible for custom drivers * Remove RGBW_BB_TWI from driver and docs * Revert changes to clipping range support * Use just rgblight_set instead of full custom driver * Convert to i2c_master commands * Rename rgblight driver and clean up includes * Use White channel on RGBW LEDs * SPI DMA based RGB Underglow for STM32 (qmk#7674) * Initial stash of ws2812 spi driver * Update comment, add sync backup plan * Add testing notes to spi ws2812 driver * Align RGBW error messages Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Jonathan Rascher <[email protected]> Co-authored-by: Florian Didron <[email protected]>
* Move Ergodox EZ RGB code to custom driver Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]> * Make Clipping range accessible for custom drivers * Remove RGBW_BB_TWI from driver and docs * Revert changes to clipping range support * Use just rgblight_set instead of full custom driver * Convert to i2c_master commands * Rename rgblight driver and clean up includes
* Move Ergodox EZ RGB code to custom driver Also implements full addressing of Ergodox EZ's LED Strip, as written by seebs Co-authored-by: Seebs <[email protected]> * Make Clipping range accessible for custom drivers * Remove RGBW_BB_TWI from driver and docs * Revert changes to clipping range support * Use just rgblight_set instead of full custom driver * Convert to i2c_master commands * Rename rgblight driver and clean up includes
Description
This pulls out the
RGBW_BB_TWIimplementation out of the core ws2812 driver, since only the Ergodox EZ actually uses this.Additionally. this adds support for fully addressing the RGB Strip in the ErgoDox EZ, rather than only just mirroring the halves.
Thanks to @seebs for the original code to implement the addressing, and thanks to @zvecr for help and inspiration
Types of Changes
Issues Fixed or Closed by This PR
Checklist