Cleanup rules.mk for F303 keyboards #7306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure is due to the California, again. Going to get my ARM toolchain set up to make absolutely sure the hashes don't change. |
|
With console and command both disabled (probably just command that compiles the build time, now that I think about it): Looks good 👍 |
noroadsleft
approved these changes
Nov 9, 2019
drashna
approved these changes
Nov 10, 2019
|
Nice. If that's the case, I may see about moving some of the Planck EZ's config into it's folder and out of the default (for sanity's sake). |
|
Thanks! |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Nov 15, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (475 commits) [Keyboard] kbdfans keyboards NKRO enable (qmk#7364) [Keyboard] fix DZ60RGB info.json (qmk#7362) Adding new pcb with default keymap and personal keymap (qmk#7314) [Core] Cleanup rules.mk for F303 keyboards (qmk#7306) [Docs] Japanese translation of docs/ja/newbs_best_practices.md (qmk#7337) Set device version from config.h for V-USB boards (qmk#7316) Add support for configurable polling interval and power usage o… (qmk#7336) capslock_led (qmk#7359) Move Ergodox EZ RGB Light code to custom driver (qmk#7309) Fix shell.nix by pinning nixpkgs (qmk#6213) [Keyboard] add kbdmini; dztech, kbdfans keyboards cleanup (qmk#7223) [Docs] Encourage newbs to not download the repo as a zip (qmk#7353) Update debounce docs (qmk#7355) [Keyboard] Add TG4x (qmk#7351) [Keyboard] Add FLX Virgo (qmk#7352) format code according to conventions [skip ci] Adding verd layout to RSII (qmk#7296) Add my custom layouts for GH60, DZ60 and Minivan (qmk#7278) [Keyboard] Added abnt2 layout to dz60 (qmk#7340) [Keyboard] add Little Keyboards as a seller of helix pcbs outside of japan (qmk#7249) ...
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Nov 18, 2019
* Cleanup rules.mk for F303 keyboards * Fix small typo
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
* Cleanup rules.mk for F303 keyboards * Fix small typo
patrl
pushed a commit
to patrl/qmk_firmware
that referenced
this pull request
Dec 29, 2019
* Cleanup rules.mk for F303 keyboards * Fix small typo
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 6, 2020
* Cleanup rules.mk for F303 keyboards * Fix small typo
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 8, 2020
* Cleanup rules.mk for F303 keyboards * Fix small typo
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
* Cleanup rules.mk for F303 keyboards * Fix small typo
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Cleanup rules.mk for F303 keyboards * Fix small typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rules.mk setup for STM32F303 is handled in mcu_selection.mk, so we should be able to just set
MCUfor these boards. Not sure if proton_c.mk could be included in this cleanup, but I believe we can also add similar stuff to mcu_selection.mk for the other supported ARM chips.Additionally, chibios.mk appears to fall back to
drivers/boards/if noboards/directory is found in the keyboard hierarchy. For the Hadron V3, HS60 V2 and NK65, theirs were functionally identical and can be removed.Types of Changes
Issues Fixed or Closed by This PR
Checklist