i2c_init update to work with atmega32a boards #5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
address ACK along with pull up resistors.
drashna
requested review from
drashna,
algernon,
fredizzimo,
jackhumbert,
skullydazed and
yanfali
…ork for all boards. Putting the new code into an ifdef block
|
Tested the changes, this seems to fix the issues that I had. Mostly, waiting on @jackhumbert to okay this. |
drashna
approved these changes
Apr 6, 2019
|
Can confirm this works on a jj4x4 (also atmega32a with i2c for underglow rgb) that has been converted to use i2c_master. WIP branch available here. |
zvecr
approved these changes
Apr 6, 2019
13 tasks
13 tasks
jackhumbert
approved these changes
Apr 7, 2019
danielo515
pushed a commit
to danielo515/qmk_firmware
that referenced
this pull request
May 15, 2019
* On i2c_init, enable two wire interface, twi interrupt, and slave address ACK along with pull up resistors. * thanks to some testing by drashna, we know that setting TWI doesn't work for all boards. Putting the new code into an ifdef block
shimesaba-type0
pushed a commit
to shimesaba-type0/qmk_firmware
that referenced
this pull request
Jun 22, 2019
* On i2c_init, enable two wire interface, twi interrupt, and slave address ACK along with pull up resistors. * thanks to some testing by drashna, we know that setting TWI doesn't work for all boards. Putting the new code into an ifdef block
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
* On i2c_init, enable two wire interface, twi interrupt, and slave address ACK along with pull up resistors. * thanks to some testing by drashna, we know that setting TWI doesn't work for all boards. Putting the new code into an ifdef block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bootmapper Client (BMC) boards have to use custom i2c instead of the QMK i2c_master driver. I would like to get rid of that dependency and modify i2c_master to support atmega32a boards. The difference actually lies in the
i2c_initroutine.In
i2c_init, enableTested working on
I don't have any other non BMC boards that make use of i2c currently in my possession that I can think of, so I could use some help testing this =).
Types of Changes
Checklist