Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panc60 Refactor #5559

Merged
merged 7 commits into from
Apr 7, 2019
Merged

Panc60 Refactor #5559

merged 7 commits into from
Apr 7, 2019

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Apr 5, 2019 •
edited
Loading

Description

  • Remove custom matrix now that we support bootmapper matrices
  • Use #pragma once everywhere
  • Update readme with the correct instructions
  • Turn on bootmagic lite

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin
Copy link
Contributor Author

This PR will be on hold until resolution of PR 5562: #5562

@mechmerlin mechmerlin changed the title Panc60 Refactor [On Hold] Panc60 Refactor Apr 6, 2019
@mechmerlin mechmerlin changed the title [On Hold] Panc60 Refactor Panc60 Refactor Apr 7, 2019
@mechmerlin
Copy link
Contributor Author

This is good to go, #5562 was merged.

@drashna
Copy link
Member

drashna commented Apr 7, 2019

Awesome!
/Rejoices in i2c

@drashna drashna merged commit 5c1ef2b into qmk:master Apr 7, 2019
danielo515 pushed a commit to danielo515/qmk_firmware that referenced this pull request May 15, 2019
@mechmerlin @danielo515
[Keyboard] Panc60 Refactor (qmk#5559)
00fee54 
* remove unneeded uart setting

* use pragma once everywhere

* remove custom matrix support

* fixup readme

* set bootmagic to lite

* remove dependency on custom i2c code

* use the right header files and function calls
shimesaba-type0 pushed a commit to shimesaba-type0/qmk_firmware that referenced this pull request Jun 22, 2019
@mechmerlin @shimesaba-type0
[Keyboard] Panc60 Refactor (qmk#5559)
a1184ab 
* remove unneeded uart setting

* use pragma once everywhere

* remove custom matrix support

* fixup readme

* set bootmagic to lite

* remove dependency on custom i2c code

* use the right header files and function calls
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@mechmerlin @Timbus
[Keyboard] Panc60 Refactor (qmk#5559)
8303486 
* remove unneeded uart setting

* use pragma once everywhere

* remove custom matrix support

* fixup readme

* set bootmagic to lite

* remove dependency on custom i2c code

* use the right header files and function calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mechmerlin @drashna