Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Docs option for ArduinoIDE's example ArduinoISP #20486

Merged
merged 8 commits into from
Apr 19, 2023
Merged

Conversation

teadetime
Copy link
Contributor

Current docs point to a specific .hex to flash to a Pro-Micro to sue it as an ISP. However, the default example ArduinoISP sketch emulates a stk500 ISP flasher. This is very accessible and should also be listed in the docs.

I confirmed this worked for my flashing atmel-dfu onto my Pro-Micro, via and Arduino Uno using the command (wiring as indicated):

avrdude -c stk500v1 -b 19200 -P /dev/ttyACM0 -p atmega32u4 -U flash:w:bootloader_atmega32u4_1.0.0.hex:i -U hfuse:w:0xD9:m -U efuse:w:0xC3:m -U lock:w:0x3F:m

Description

Added corresponding wiring, description and avrdude parameters to guide.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
docs/isp_flashing_guide.md Outdated Show resolved Hide resolved
@teadetime
Copy link
Contributor Author

Thanks for the quick review and good edits -- couldn't track down the B5 etc. labels for the Uno so wasn't sure if they were the same. Let me know if any other changes to be made.

@teadetime teadetime requested a review from fauxpark April 18, 2023 02:53
@teadetime
Copy link
Contributor Author

Thanks for the quick review and good edits -- couldn't track down the B5 etc. labels for the Uno so wasn't sure if they were the same. Let me know if any other changes to be made.

@fauxpark made the requested changes

Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I'm not actually sure where the .hex files in the repo came from, so perhaps this Arduino method should completely replace them instead. Just thinking out loud.

@fauxpark fauxpark requested a review from a team April 19, 2023 18:17
@zvecr zvecr merged commit 952cdc7 into qmk:master Apr 19, 2023
quangd42 pushed a commit to quangd42/qmk_firmware that referenced this pull request Apr 20, 2023
queyenth pushed a commit to queyenth/qmk_firmware that referenced this pull request Apr 21, 2023
stratosgear pushed a commit to stratosgear/qmk_firmware that referenced this pull request Apr 26, 2023
struckmb pushed a commit to struckmb/qmk_firmware that referenced this pull request May 1, 2023
rodrigob pushed a commit to rodrigob/qmk_firmware that referenced this pull request May 2, 2023
SjB added a commit to SjB/qmk_firmware that referenced this pull request May 12, 2023
* master:
  NK Plus (qmk#20392)
  [Docs] Fix suggested code pattern when a specific mod-mask is required. (qmk#20512)
  [Docs] Remove combo count from array (qmk#20511)
  Add QuadrumLabs Delta (qmk#20409)
  Adds Docs option for ArduinoIDE's example `ArduinoISP` (qmk#20486)
  GMMK 2 volume up/down Fn keys are backwards in default mapping (qmk#20476)
  Fix typo in `feature_wpm.md` title (qmk#20464)
  [Keyboard] Add Kalakos Bahrnob65 (qmk#20424)
  Tidy up stray RGB_DISABLE_TIMEOUT references (qmk#20460)
  [Keyboard] Add zoom75 wired (qmk#20396)
  [Keyboard] Add dymium65 (qmk#20257)
  Lotus58 glow (qmk#20386)
  ADPenrose Obi Layout Macro Conversion and Addition (qmk#20445)
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants