Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add dymium65 #20257

Merged
merged 25 commits into from
Apr 15, 2023
Merged

[Keyboard] Add dymium65 #20257

merged 25 commits into from
Apr 15, 2023

Conversation

Wycers
Copy link
Contributor

@Wycers Wycers commented Mar 25, 2023

Description

Add dymium65 keyboard to QMK.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 25, 2023
@Wycers
Copy link
Contributor Author

Wycers commented Mar 25, 2023 •
edited
Loading

Sorry for the basic mistakes in the previous PR #19783...We decide to close it to maintain a clean git history.

@zvecr zvecr added the pr_checklist_pending Needs changes as per the PR checklist label Mar 25, 2023
@Wycers Wycers requested a review from zvecr March 27, 2023 07:07
waffle87
waffle87 requested changes Mar 28, 2023
View reviewed changes
keyboards/dotmod/dymium65/dymium65.h Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/info.json Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/dymium65.c Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/keymaps/via/keymap.c Outdated Show resolved Hide resolved
lesshonor
lesshonor suggested changes Mar 31, 2023
View reviewed changes
keyboards/dotmod/dymium65/config.h Show resolved Hide resolved
keyboards/dotmod/dymium65/info.json Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/info.json Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/info.json Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/dymium65.c Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/dymium65.c Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/readme.md Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/readme.md Outdated Show resolved Hide resolved
@Wycers Wycers requested a review from lesshonor April 2, 2023 09:57
@Wycers Wycers requested a review from waffle87 April 4, 2023 08:22
drashna
drashna requested changes Apr 6, 2023
View reviewed changes
keyboards/dotmod/dymium65/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/dotmod/dymium65/dymium65.c Show resolved Hide resolved
keyboards/dotmod/dymium65/readme.md Outdated Show resolved Hide resolved
Linyer-qwq and others added 2 commits April 6, 2023 11:36
@Linyer-qwq @drashna
Update keyboards/dotmod/dymium65/readme.md
2d38ae7 
Co-authored-by: Drashna Jaelre <[email protected]>
@Linyer-qwq @drashna
Apply suggestions from code review
c94dd74 
Move rgb_matrix_indicators_advanced_user to keyboards/dotmod/dymium65/dymium65.c

Co-authored-by: Drashna Jaelre <[email protected]>
@Wycers Wycers requested a review from drashna April 10, 2023 09:03
@drashna drashna requested review from a team and removed request for lesshonor April 15, 2023 10:27
@waffle87 waffle87 changed the title Add dymium65 keyboard to QMK [Keyboard] Add dymium65 Apr 15, 2023
@waffle87 waffle87 merged commit 75b7140 into qmk:master Apr 15, 2023
sudish added a commit to sudish/qmk_firmware that referenced this pull request Apr 16, 2023
@sudish
Merge remote-tracking branch 'upstream/master'
4130864 
* upstream/master: (73 commits)
  [Keyboard] Add Kalakos Bahrnob65 (qmk#20424)
  Tidy up stray RGB_DISABLE_TIMEOUT references (qmk#20460)
  [Keyboard] Add zoom75 wired (qmk#20396)
  [Keyboard] Add dymium65 (qmk#20257)
  Lotus58 glow (qmk#20386)
  ADPenrose Obi Layout Macro Conversion and Addition (qmk#20445)
  Add hardware information momokai keyboards (qmk#20434)
  4pplet/eagle_viper_rep/rev_a Layout Macro Conversion and Additions (qmk#20414)
  [Keymap] Add paulomp90 lily58 keymap (qmk#20327)
  [Keymap] Add personal keymap for Lily58 (qmk#18735)
  [Keyboard] Fix h87 g2 VID conflict (qmk#20388)
  [Keymap] PHSC138 Keymap for Atom47 (qmk#18768)
  [Keyboard] add kb2040 flavor of gherkin (qmk#18360)
  [Keyboard] ymdk/id75 (qmk#19967)
  fixing bug that caused KC_DEL and KC_MUTE (encoder press) to be swapped (qmk#20420)
  4pplet/bootleg/rev_a Layout Macro Conversion and Addition (qmk#20400)
  4pplet/aekiso60 Layout Macro Conversion and Additions (qmk#20399)
  Reject info.json at keymap level (qmk#20408)
  Bump anothrNick/github-tag-action from 1.61.0 to 1.62.0 (qmk#20407)
  [Keyboard] Update angle65 VID/PID (qmk#20401)
  ...
rodrigob pushed a commit to rodrigob/qmk_firmware that referenced this pull request Apr 18, 2023
@Wycers @lesshonor
@drashna @Linyer-qwq @rodrigob
[Keyboard] Add dymium65 (qmk#20257)
37ed6f1 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: Wycer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: linyer-qwq <[email protected]>
Co-authored-by: Linyer-qwq <[email protected]>
quangd42 pushed a commit to quangd42/qmk_firmware that referenced this pull request Apr 20, 2023
@Wycers @lesshonor
@drashna @Linyer-qwq @quangd42
[Keyboard] Add dymium65 (qmk#20257)
a41fc09 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: Wycer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: linyer-qwq <[email protected]>
Co-authored-by: Linyer-qwq <[email protected]>
queyenth pushed a commit to queyenth/qmk_firmware that referenced this pull request Apr 21, 2023
@Wycers @lesshonor
@drashna @Linyer-qwq @queyenth
[Keyboard] Add dymium65 (qmk#20257)
b7031ac 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: Wycer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: linyer-qwq <[email protected]>
Co-authored-by: Linyer-qwq <[email protected]>
stratosgear pushed a commit to stratosgear/qmk_firmware that referenced this pull request Apr 26, 2023
@Wycers @lesshonor
@drashna @Linyer-qwq @stratosgear
[Keyboard] Add dymium65 (qmk#20257)
b192644 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: Wycer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: linyer-qwq <[email protected]>
Co-authored-by: Linyer-qwq <[email protected]>
struckmb pushed a commit to struckmb/qmk_firmware that referenced this pull request May 1, 2023
@Wycers @lesshonor
@drashna @Linyer-qwq @struckmb
[Keyboard] Add dymium65 (qmk#20257)
4069e77 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: Wycer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: linyer-qwq <[email protected]>
Co-authored-by: Linyer-qwq <[email protected]>
@shangmingzhang shangmingzhang mentioned this pull request May 6, 2023
Merged
7 tasks
SjB added a commit to SjB/qmk_firmware that referenced this pull request May 12, 2023
@SjB
Merge branch 'master' into sjb/all-keyboard
6422db5 
* master:
  NK Plus (qmk#20392)
  [Docs] Fix suggested code pattern when a specific mod-mask is required. (qmk#20512)
  [Docs] Remove combo count from array (qmk#20511)
  Add QuadrumLabs Delta (qmk#20409)
  Adds Docs option for ArduinoIDE's example `ArduinoISP` (qmk#20486)
  GMMK 2 volume up/down Fn keys are backwards in default mapping (qmk#20476)
  Fix typo in `feature_wpm.md` title (qmk#20464)
  [Keyboard] Add Kalakos Bahrnob65 (qmk#20424)
  Tidy up stray RGB_DISABLE_TIMEOUT references (qmk#20460)
  [Keyboard] Add zoom75 wired (qmk#20396)
  [Keyboard] Add dymium65 (qmk#20257)
  Lotus58 glow (qmk#20386)
  ADPenrose Obi Layout Macro Conversion and Addition (qmk#20445)
@shangmingzhang shangmingzhang mentioned this pull request Aug 21, 2023
Merged
7 tasks
@shangmingzhang shangmingzhang mentioned this pull request Sep 5, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesshonor lesshonor lesshonor requested changes

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap pr_checklist_pending Needs changes as per the PR checklist via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Wycers @drashna @zvecr @waffle87 @lesshonor @Linyer-qwq