Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Remove broken link #19321

Merged
merged 1 commit into from
Dec 14, 2022
Merged

[Docs] Remove broken link #19321

merged 1 commit into from
Dec 14, 2022

Conversation

elpekenin
Copy link
Contributor

Description

Just noticed a broken link while reading Tap Dance's documentation. Removed it
I don't speak japanese, so i may have do it wrong on that translation, chinese didn't have a Tap Dance file.

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark
Copy link
Member

Docs shouldn't be linking to random users' code anyway.

@fauxpark fauxpark requested a review from a team December 14, 2022 11:09
@tzarc tzarc merged commit 99174ed into qmk:master Dec 14, 2022
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@elpekenin @crembz
[Docs] Remove broken link (qmk#19321)
0ecea8c
@elpekenin elpekenin deleted the broken-link branch December 20, 2022 17:40
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@elpekenin
[Docs] Remove broken link (qmk#19321)
e50d7e8
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@elpekenin @omikronik
[Docs] Remove broken link (qmk#19321)
faa8a13
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@elpekenin @ideas32
[Docs] Remove broken link (qmk#19321)
a1b4270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elpekenin @fauxpark @tzarc