Correct keyboard_name for Unicomp Classic/Ultra Classic keyboards #18327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Sep 12, 2022
zvecr
approved these changes
Sep 12, 2022
tacahiroy
pushed a commit
to tacahiroy/qmk_firmware
that referenced
this pull request
Oct 2, 2022
SjB
added a commit
to SjB/qmk_firmware
that referenced
this pull request
Oct 12, 2022
* upstream/master: (319 commits) Fix handwired/swiftrax/bumblebee layout macro (qmk#18377) [Keyboard] Add pi40 (qmk#18207) [Keyboard] Removal of deprecated defines in IDOBAO keyboards (qmk#18358) Fix problem that Chidori is not recognized by host computer. (qmk#17882) [Keyboard] Add a new keyboard 'plum47' (qmk#18359) [Docs] RESET -> QK_BOOT (qmk#18365) Remove `RESET` keycodes from fjlabs keyboards (qmk#18364) [Keyboard] Add Vector PCB (qmk#17380) [Keyboard] Add Calice (qmk#17929) GeonWorks Frog Mini Soldered Layout Rework (qmk#18308) [Keyboard] Add skmt/15k keyboard (qmk#18321) [Keyboard] Replace Nayeon ATmega32u4 config with RP2040 (qmk#18265) Bump anothrNick/github-tag-action from 1.42.0 to 1.45.0 (qmk#18355) fix: Remove TERM_ON/TERM_OFF from my keymap (qmk#18354) Bump anothrNick/github-tag-action from 1.39.0 to 1.42.0 (qmk#18344) Fix keyboard_name for Unicomp Classic/Ultra Classic keyboards (qmk#18327) Add EM.8 keyboard (qmk#18328) fixed missing x coordinate on spacebar (qmk#18330) GMMK2: Fix 'ISO' within product name (qmk#18322) Added gmmk v2 p65 keyboard. (qmk#18185) ...
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct keyboard_name for Unicomp Classic/Ultra Classic keyboards.
Setting originally in config.h was wrong due to a copy-paste mistake, and then the wrong value was migrated to info.json sometime in August.
Types of Changes
Issues Fixed or Closed by This PR
Checklist