Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vector PCB to QMK #17380

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Add Vector PCB to QMK #17380

merged 3 commits into from
Sep 14, 2022

Conversation

awkannan
Copy link
Contributor

@awkannan awkannan commented Jun 13, 2022 •
edited
Loading

Description

Adding Vector keyboard to QMK

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 13, 2022
keyboard-magpie
keyboard-magpie requested changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting suggestions.

keyboards/cannonkeys/vector/readme.md Outdated Show resolved Hide resolved
keyboards/cannonkeys/vector/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/vector/keymaps/default/keymap.c Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Aug 17, 2022
View reviewed changes
keyboards/cannonkeys/vector/config.h Outdated Show resolved Hide resolved
keyboards/cannonkeys/vector/info.json Show resolved Hide resolved
@awkannan
Copy link
Contributor Author

@zvecr this one should be good to go now.
Thank you for the callout on moving things into info.json and removing config.h

I merged master in so I could test that it all worked - it does.

@drashna drashna requested a review from a team August 30, 2022 23:48
@awkannan
Copy link
Contributor Author

Hey @drashna thank you for the approval :)
I just wanted to bump this up a bit as its been a few weeks.

@drashna drashna merged commit 017398c into qmk:master Sep 14, 2022
@awkannan awkannan mentioned this pull request Sep 16, 2022
Merged
6 tasks
ohlin added a commit to ohlin/qmk_firmware that referenced this pull request Sep 19, 2022
@ohlin
Merge branch 'master' into ko-kyria
520554d 
* master: (28 commits)
  [Docs] Extract 'Layer Change Code' and EEPROM (qmk#18174)
  Add home row modifiers to dshields keymaps. (qmk#18376)
  Reduce charue/sunsetter_r2 firmware size (qmk#18378)
  Add encoder map to BDN9 VIA keymap (qmk#18388)
  FIx ARRAYSIZE def and Murphpad string array (qmk#18392)
  Fixup axon40 lint. (qmk#18409)
  [keyboard] kbdfans/kbd75rgb info.json fix (qmk#18391)
  Bump anothrNick/github-tag-action from 1.45.0 to 1.46.0 (qmk#18386)
  Quark revision - rotary encoder and 7u support (qmk#17664)
  Initial support for Tetromino added (qmk#18341)
  Add ability to remove temporary files during multibuild. (qmk#18381)
  Fix handwired/swiftrax/bumblebee layout macro (qmk#18377)
  [Keyboard] Add pi40 (qmk#18207)
  [Keyboard] Removal of deprecated defines in IDOBAO keyboards (qmk#18358)
  Fix problem that Chidori is not recognized by host computer. (qmk#17882)
  [Keyboard] Add a new keyboard 'plum47' (qmk#18359)
  [Docs] RESET -> QK_BOOT (qmk#18365)
  Remove `RESET` keycodes from fjlabs keyboards (qmk#18364)
  [Keyboard] Add Vector PCB (qmk#17380)
  [Keyboard] Add Calice (qmk#17929)
  ...
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@awkannan @tacahiroy
[Keyboard] Add Vector PCB (qmk#17380)
79a3899
SjB added a commit to SjB/qmk_firmware that referenced this pull request Oct 12, 2022
@SjB
Merge remote-tracking branch 'upstream/master' into sjb/all-keyboard
8def421 
* upstream/master: (319 commits)
  Fix handwired/swiftrax/bumblebee layout macro (qmk#18377)
  [Keyboard] Add pi40 (qmk#18207)
  [Keyboard] Removal of deprecated defines in IDOBAO keyboards (qmk#18358)
  Fix problem that Chidori is not recognized by host computer. (qmk#17882)
  [Keyboard] Add a new keyboard 'plum47' (qmk#18359)
  [Docs] RESET -> QK_BOOT (qmk#18365)
  Remove `RESET` keycodes from fjlabs keyboards (qmk#18364)
  [Keyboard] Add Vector PCB (qmk#17380)
  [Keyboard] Add Calice (qmk#17929)
  GeonWorks Frog Mini Soldered Layout Rework (qmk#18308)
  [Keyboard] Add skmt/15k keyboard (qmk#18321)
  [Keyboard] Replace Nayeon ATmega32u4 config with RP2040 (qmk#18265)
  Bump anothrNick/github-tag-action from 1.42.0 to 1.45.0 (qmk#18355)
  fix: Remove TERM_ON/TERM_OFF from my keymap (qmk#18354)
  Bump anothrNick/github-tag-action from 1.39.0 to 1.42.0 (qmk#18344)
  Fix keyboard_name for Unicomp Classic/Ultra Classic keyboards (qmk#18327)
  Add EM.8 keyboard  (qmk#18328)
  fixed missing x coordinate on spacebar (qmk#18330)
  GMMK2: Fix 'ISO' within product name (qmk#18322)
  Added gmmk v2 p65 keyboard. (qmk#18185)
  ...
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@awkannan @ramonimbao
[Keyboard] Add Vector PCB (qmk#17380)
8a11967
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@awkannan @nolanseaton
[Keyboard] Add Vector PCB (qmk#17380)
18ab940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@keyboard-magpie keyboard-magpie keyboard-magpie requested changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@awkannan @drashna @fauxpark @zvecr @keyboard-magpie