[Docs] update pr_checklist.md with info about data-driven #18068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm flexible on the wording of the first line of the info.json part- appreciate feedback.
drashna
approved these changes
Aug 15, 2022
zvecr
reviewed
Aug 15, 2022
spidey3
approved these changes
Aug 15, 2022
drashna
reviewed
Aug 15, 2022
| - valid URL | ||
| - valid maintainer | ||
| - valid USB VID/PID and device version | ||
| - displays correctly in Configurator (press Ctrl+Shift+I to preview local file, turn on fast input to verify ordering) |
There was a problem hiding this comment.
I think that qmk info --layouts can also output a quick reference of it too.
There was a problem hiding this comment.
How would you prefer that to be incorporated into the list?
There was a problem hiding this comment.
Is the intention here just that the visual rendering is accurate, or the implementation as well?
I have very little confidence that this will improve the rate of proper Configurator implementations at PR creation time.
noroadsleft
previously requested changes
Aug 15, 2022
Co-authored-by: James Young <[email protected]>
imhoffman
pushed a commit
to imhoffman/qmk_firmware
that referenced
this pull request
Aug 20, 2022
* update pr_checklist with info about data-driven Co-authored-by: James Young <[email protected]>
SjB
added a commit
to SjB/qmk_firmware
that referenced
this pull request
Aug 27, 2022
* upstream/master: (595 commits) [Keyboard] Add ibis80 (qmk#18051) [Keymap] toshi0383 keymaps update (qmk#18073) [Docs] Use layer number as example for COMBO_ONLY_FROM_LAYER (qmk#18072) [Keymap] jotix's community/ortho4x12 change (qmk#18069) Adjust the hierarchy of chapter `Deferred Execution` (qmk#18075) Fix WS2812 order for aurora65 and loki65 (qmk#18074) [Docs] update pr_checklist.md with info about data-driven (qmk#18068) Use correct board file in xelus/valor_frl_tkl/rev2_0 (qmk#18071) Migrate more F4x1 board files (qmk#18054) ADB to USB converter: split into rev1 and rev2 (qmk#18052) Move keyboard USB IDs and strings to data driven, pass 2: D-E (qmk#17956) Move keyboard USB IDs and strings to data driven, pass 2: F-I (qmk#17958) Allow disabling RGB_MATRIX_ANIMATIONS system76 keyboards (qmk#17478) Migrate more F4x1 board files (qmk#18046) Feat/port ft mars 65 (qmk#17994) Improve Drop Alt compatibility with VIA (qmk#18041) [Keyboard] Add Valor FRL TKL rev2.0 and 2.1 (qmk#17992) Move keyboard USB IDs and strings to data driven, pass 2: B-C (qmk#17945) [Keyboard] add bajjak keyboard (qmk#12377) Add texts for Discord Events to be created post-merge. (qmk#17944) ...
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
* update pr_checklist with info about data-driven Co-authored-by: James Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to improve PR checklist again. This time with DD info.
I'm flexible on the wording of the first line of the info.json part- appreciate feedback.
Types of Changes
Issues Fixed or Closed by This PR
Checklist