Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] add bajjak keyboard #12377

Merged
merged 30 commits into from
Aug 14, 2022
Merged

[Keyboard] add bajjak keyboard #12377

merged 30 commits into from
Aug 14, 2022

Conversation

garykong
Copy link

@garykong garykong commented Mar 25, 2021 •
edited
Loading

Description

This keyboard is a 6x7 array keyboard based on ergodox ez.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Apr 3, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have rgb matrix or rgb light support?
If not, then you may want to remove the code and config for it.

And you may want to rename the function from ergodox to bajjak

keyboards/bajjak/keymaps/5x6/keymap.c Show resolved Hide resolved
keyboards/bajjak/keymaps/default/keymap.c Show resolved Hide resolved
@garykong
Copy link
Author

garykong commented Apr 6, 2021 •
edited
Loading

Dear @drashna

  1. Does this have rgb matrix or rgb light support?
  • I haven't deleted the source code for those who need this feature.
  1. Add GPL2 + license in keymap.c
  2. Renamed the function from ergodox to bajjak

@garykong garykong requested a review from drashna April 6, 2021 09:16
@drashna
Copy link
Member

drashna commented Apr 19, 2021

  • I haven't deleted the source code for those who need this feature.

Does the hardware physically support it? If not (especially in the case of the rgb matrix), then it should be removed.

@garykong
Copy link
Author

garykong commented Apr 21, 2021 •
edited
Loading

  • I haven't deleted the source code for those who need this feature.

Does the hardware physically support it? If not (especially in the case of the rgb matrix), then it should be removed.

@drashna Removed RGB related code.

@garykong
Copy link
Author

garykong commented May 4, 2021

@drashna Could you please check?

drashna
drashna reviewed May 14, 2021
View reviewed changes
keyboards/bajjak/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team May 14, 2021 03:25
@garykong
Copy link
Author

@drashna Please confirm this review.

@drashna drashna requested a review from a team July 3, 2021 05:09
fauxpark
fauxpark requested changes Jul 3, 2021
View reviewed changes
keyboards/bajjak/rules.mk Outdated Show resolved Hide resolved
keyboards/bajjak/readme.md Outdated Show resolved Hide resolved
keyboards/bajjak/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/bajjak/config.h Outdated Show resolved Hide resolved
keyboards/bajjak/bajjak.h Outdated Show resolved Hide resolved
@garykong garykong requested a review from fauxpark July 6, 2021 08:44
drashna
drashna requested changes Jun 13, 2022
View reviewed changes
keyboards/bajjak/config.h Outdated Show resolved Hide resolved
@garykong garykong requested a review from drashna June 14, 2022 02:21
garykong
garykong commented Jun 14, 2022
View reviewed changes
Copy link
Author

@garykong garykong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request a review.

drashna
drashna reviewed Jun 14, 2022
View reviewed changes
keyboards/bajjak/readme.md Outdated Show resolved Hide resolved
@garykong garykong requested a review from drashna June 20, 2022 01:32
noroadsleft
noroadsleft requested changes Jul 16, 2022
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drashna's comment regarding the readme file still needs action.

Also, be advised that the VRSN will probably not work. version.h no longer gets compiled by QMK, so the data the keycode needs to work does not exist in the compiled firmware.

keyboards/bajjak/bajjak.h Outdated Show resolved Hide resolved
keyboards/bajjak/info.json Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Aug 10, 2022
View reviewed changes
keyboards/bajjak/readme.md Outdated Show resolved Hide resolved
keyboards/bajjak/rules.mk Outdated Show resolved Hide resolved
keyboards/bajjak/rules.mk Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Aug 10, 2022
View reviewed changes
keyboards/bajjak/readme.md Outdated Show resolved Hide resolved
@drashna drashna merged commit 28b05d1 into qmk:master Aug 14, 2022
@garykong garykong deleted the dev_branch branch August 15, 2022 23:30
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@garykong @drashna
@fauxpark @peepeetee @noroadsleft @imhoffman
[Keyboard] add bajjak keyboard (qmk#12377)
66dc0ef 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: peepeetee <[email protected]>
Co-authored-by: James Young <[email protected]>
SjB added a commit to SjB/qmk_firmware that referenced this pull request Aug 27, 2022
@SjB
Merge remote-tracking branch 'upstream/master' into sjb/all-keyboard
021168a 
* upstream/master: (595 commits)
  [Keyboard] Add ibis80 (qmk#18051)
  [Keymap] toshi0383 keymaps update (qmk#18073)
  [Docs] Use layer number as example for COMBO_ONLY_FROM_LAYER (qmk#18072)
  [Keymap] jotix's community/ortho4x12 change (qmk#18069)
  Adjust the hierarchy of chapter `Deferred Execution` (qmk#18075)
  Fix WS2812 order for aurora65 and loki65 (qmk#18074)
  [Docs] update pr_checklist.md with info about data-driven (qmk#18068)
  Use correct board file in xelus/valor_frl_tkl/rev2_0 (qmk#18071)
  Migrate more F4x1 board files (qmk#18054)
  ADB to USB converter: split into rev1 and rev2 (qmk#18052)
  Move keyboard USB IDs and strings to data driven, pass 2: D-E (qmk#17956)
  Move keyboard USB IDs and strings to data driven, pass 2: F-I (qmk#17958)
  Allow disabling RGB_MATRIX_ANIMATIONS system76 keyboards (qmk#17478)
  Migrate more F4x1 board files (qmk#18046)
  Feat/port ft mars 65 (qmk#17994)
  Improve Drop Alt compatibility with VIA (qmk#18041)
  [Keyboard] Add Valor FRL TKL rev2.0 and 2.1 (qmk#17992)
  Move keyboard USB IDs and strings to data driven, pass 2: B-C (qmk#17945)
  [Keyboard] add bajjak keyboard (qmk#12377)
  Add texts for Discord Events to be created post-merge. (qmk#17944)
  ...
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@garykong @drashna
@fauxpark @peepeetee @noroadsleft @nolanseaton
[Keyboard] add bajjak keyboard (qmk#12377)
dea141f 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: peepeetee <[email protected]>
Co-authored-by: James Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peepeetee peepeetee peepeetee requested changes

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garykong @drashna @fauxpark @noroadsleft @peepeetee