Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move keyboard USB IDs and strings to data driven: E #17815

Merged
merged 3 commits into from
Jul 30, 2022
Merged

Move keyboard USB IDs and strings to data driven: E #17815

merged 3 commits into from
Jul 30, 2022

Conversation

fauxpark
Copy link
Member

Description

Previous PR: #17814

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team July 27, 2022 06:33
@fauxpark fauxpark mentioned this pull request Jul 27, 2022
Merged
14 tasks
@fauxpark
Copy link
Member Author

Lint errors are unrelated.

@drashna drashna requested a review from a team July 29, 2022 06:55
@fauxpark fauxpark merged commit 1c6b039 into qmk:master Jul 30, 2022
@fauxpark fauxpark deleted the keyboards-data-driven-usb-e branch July 30, 2022 07:24
@keyboard-magpie keyboard-magpie mentioned this pull request Aug 1, 2022
Merged
14 tasks
mincedshon added a commit to mincedshon/qmk_firmware that referenced this pull request Aug 1, 2022
@mincedshon
update files based on PR qmk#17815
7a2c7d5 
-moved USB IDs and strings based on PR qmk#17815
-updated readme.md from requested changes
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@fauxpark @imhoffman
Move keyboard USB IDs and strings to data driven: E (qmk#17815)
a5c3f82
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@fauxpark @nolanseaton
Move keyboard USB IDs and strings to data driven: E (qmk#17815)
9079507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna