Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move keyboard USB IDs and strings to data driven: D #17814

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Move keyboard USB IDs and strings to data driven: D #17814

merged 1 commit into from
Jul 30, 2022

Conversation

fauxpark
Copy link
Member

Description

Previous PR #17789

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team July 27, 2022 05:37
@fauxpark fauxpark mentioned this pull request Jul 27, 2022
Merged
14 tasks
KarlK90
KarlK90 approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drashna
Copy link
Member

drashna commented Jul 27, 2022

should probably target develop. Have already ran into merge conflicts, with the B PR due to changes to the boardsource boards.

@fauxpark
Copy link
Member Author

I don't recall getting an email that the develop merge failed? Unless you mean merge conflicts with other PRs, in which case they would need to be resolved. These aren't core changes.

@fauxpark
Copy link
Member Author

Lint errors are unrelated.

@drashna
Copy link
Member

drashna commented Jul 29, 2022

I don't recall getting an email that the develop merge failed? Unless you mean merge conflicts with other PRs, in which case they would need to be resolved. These aren't core changes.

It definitely failed the merge. Not sure why it failed to send a notification.

https://github.com/qmk/qmk_firmware/actions/runs/2733376752

I'm not sure if any others will have issues, though.

@drashna drashna merged commit 306e50b into qmk:master Jul 30, 2022
@fauxpark fauxpark deleted the keyboards-data-driven-usb-d branch July 30, 2022 03:34
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@fauxpark @imhoffman
Move keyboard USB IDs and strings to data driven: D (qmk#17814)
2bff399
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@fauxpark @nolanseaton
Move keyboard USB IDs and strings to data driven: D (qmk#17814)
d79892b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fauxpark @drashna @KarlK90