Updates to follow code style, depracations

This includes all of @drashna's suggestions on a pull request to include `pdl` layouts which can be accepted and added automatically. Suggestions given in text will require a separate commit.

Co-authored-by: Drashna Jaelre <[email protected]>

keyboards/foostan/cornelius/keymaps/pdl/config.h

@@ -21,11 +21,9 @@ along with this program. If not, see <http:https://www.gnu.org/licenses/>.
 
 #pragma once
 
-#include "../../config.h"
 
 #define TAPPING_TOGGLE 2
 #define TAPPING_TERM 200
-#define PREVENT_STUCK_MODIFIERS
 
 #define COMBO_PDL
 #define COMBO_COUNT 28

keyboards/foostan/cornelius/keymaps/pdl/keymap.c

@@ -15,7 +15,6 @@
  */
 #include QMK_KEYBOARD_H
 #include "pdl.c"
-extern keymap_config_t keymap_config;
 
 const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
  [_QWERTY] = KEYMAP_wrapper( \

keyboards/handwired/reclined/config.h

@@ -25,7 +25,6 @@ along with this program. If not, see <http:https://www.gnu.org/licenses/>.
 #define DEVICE_VER 0x0001
 #define MANUFACTURER pdl
 #define PRODUCT reclined
-#define DESCRIPTION A custom staggered 40 percent keyboard split at 22.5 degrees
 
 /* key matrix size */
 #define MATRIX_ROWS 4
@@ -49,7 +48,7 @@ along with this program. If not, see <http:https://www.gnu.org/licenses/>.
 #define DIODE_DIRECTION ROW2COL
 
 /* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
-#define DEBOUNCING_DELAY 5
+#define DEBOUNCE 5
 
 /* define if matrix has ghost (lacks anti-ghosting diodes) */
 //#define MATRIX_HAS_GHOST
@@ -93,46 +92,6 @@ along with this program. If not, see <http:https://www.gnu.org/licenses/>.
  *
  */
 
-/* key combination for magic key command */
-#define IS_COMMAND() ( \
- keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
-)
-
-/* control how magic key switches layers */
-//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true
-//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true
-//#define MAGIC_KEY_SWITCH_LAYER_WITH_CUSTOM false
-
-/* override magic key keymap */
-//#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS
-//#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS
-//#define MAGIC_KEY_SWITCH_LAYER_WITH_CUSTOM
-//#define MAGIC_KEY_HELP1 H
-//#define MAGIC_KEY_HELP2 SLASH
-//#define MAGIC_KEY_DEBUG D
-//#define MAGIC_KEY_DEBUG_MATRIX X
-//#define MAGIC_KEY_DEBUG_KBD K
-//#define MAGIC_KEY_DEBUG_MOUSE M
-//#define MAGIC_KEY_VERSION V
-//#define MAGIC_KEY_STATUS S
-//#define MAGIC_KEY_CONSOLE C
-//#define MAGIC_KEY_LAYER0_ALT1 ESC
-//#define MAGIC_KEY_LAYER0_ALT2 GRAVE
-//#define MAGIC_KEY_LAYER0 0
-//#define MAGIC_KEY_LAYER1 1
-//#define MAGIC_KEY_LAYER2 2
-//#define MAGIC_KEY_LAYER3 3
-//#define MAGIC_KEY_LAYER4 4
-//#define MAGIC_KEY_LAYER5 5
-//#define MAGIC_KEY_LAYER6 6
-//#define MAGIC_KEY_LAYER7 7
-//#define MAGIC_KEY_LAYER8 8
-//#define MAGIC_KEY_LAYER9 9
-//#define MAGIC_KEY_BOOTLOADER PAUSE
-//#define MAGIC_KEY_LOCK CAPS
-//#define MAGIC_KEY_EEPROM E
-//#define MAGIC_KEY_NKRO N
-//#define MAGIC_KEY_SLEEP_LED Z
 
 /*
  * Feature disable options
@@ -152,25 +111,3 @@ along with this program. If not, see <http:https://www.gnu.org/licenses/>.
 //#define NO_ACTION_MACRO
 //#define NO_ACTION_FUNCTION
 
-/*
- * MIDI options
- */
-
-/* Prevent use of disabled MIDI features in the keymap */
-//#define MIDI_ENABLE_STRICT 1
-
-/* enable basic MIDI features:
- - MIDI notes can be sent when in Music mode is on
-*/
-//#define MIDI_BASIC
-
-/* enable advanced MIDI features:
- - MIDI notes can be added to the keymap
- - Octave shift and transpose
- - Virtual sustain, portamento, and modulation wheel
- - etc.
-*/
-//#define MIDI_ADVANCED
-
-/* override number of MIDI tone keycodes (each octave adds 12 keycodes and allocates 12 bytes) */
-//#define MIDI_TONE_KEYCODE_OCTAVES 1

keyboards/handwired/reclined/keymaps/default/keymap.c

@@ -24,38 +24,3 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
 ),
 };
 
-const uint16_t PROGMEM fn_actions[] = {
-
-};
-
-const macro_t *action_get_macro(keyrecord_t *record, uint8_t id, uint8_t opt)
-{
- // MACRODOWN only works in this function
- switch(id) {
- case 0:
- if (record->event.pressed) {
- register_code(KC_RSFT);
- } else {
- unregister_code(KC_RSFT);
- }
- break;
- }
- return MACRO_NONE;
-};
-
-
-void matrix_init_user(void) {
-
-}
-
-void matrix_scan_user(void) {
-
-}
-
-bool process_record_user(uint16_t keycode, keyrecord_t *record) {
- return true;
-}
-
-void led_set_user(uint8_t usb_led) {
-
-}

keyboards/handwired/reclined/keymaps/pdl/config.h

@@ -18,12 +18,6 @@ You should have received a copy of the GNU General Public License
 along with this program. If not, see <http:https://www.gnu.org/licenses/>.
 */
 
-#ifndef CONFIG_USER_H
-#define CONFIG_USER_H
-
-#include "../../config.h"
+#pragma once
 
 #define TAPPING_TERM 200
-#define PREVENT_STUCK_MODIFIERS
-
-#endif

keyboards/handwired/reclined/keymaps/pdl/keymap.c

@@ -22,7 +22,6 @@ along with this program. If not, see <http:https://www.gnu.org/licenses/>.
 
 #include QMK_KEYBOARD_H
 #include "pdl.c"
-extern keymap_config_t keymap_config;
 
 const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
  [_QWERTY] = KEYMAP_wrapper( \

keyboards/handwired/reclined/rules.mk

@@ -1,34 +1,8 @@
 # MCU name
 MCU = atmega32u4
 
-# Processor frequency.
-# This will define a symbol, F_CPU, in all source code files equal to the
-# processor frequency in Hz. You can then use this symbol in your source code to
-# calculate timings. Do NOT tack on a 'UL' at the end, this will be done
-# automatically to create a 32-bit value in your source code.
-#
-# This will be an integer division of F_USB below, as it is sourced by
-# F_USB after it has run through any CPU prescalers. Note that this value
-# does not *change* the processor frequency - it should merely be updated to
-# reflect the processor speed set externally so that the code can use accurate
-# software delays.
-F_CPU = 16000000
-
-
-#
-# LUFA specific
-#
-# Target architecture (see library "Board Types" documentation).
-ARCH = AVR8
-
-# Input clock frequency.
-F_USB = $(F_CPU)
-
-# Interrupt driven control endpoint task(+60)
-OPT_DEFS += -DINTERRUPT_CONTROL_ENDPOINT
-
-# Boot Section Size in *bytes*
-OPT_DEFS += -DBOOTLOADER_SIZE=4096
+# Bootloader selection
+BOOTLOADER = atmel-dfu
 
 # Build Options
 # change yes to no to disable
@@ -44,5 +18,5 @@ SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend
 NKRO_ENABLE = no # USB Nkey Rollover
 BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality on B7 by default
 UNICODE_ENABLE = no # Unicode
-BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID
-AUDIO_ENABLE = no # Audio output on port C6
+BLUETOOTH_ENABLE = no # Enable Bluetooth
+AUDIO_ENABLE = no # Audio output

keyboards/lets_split/keymaps/pdl/config.h

@@ -21,10 +21,8 @@ along with this program. If not, see <http:https://www.gnu.org/licenses/>.
 
 #pragma once
 
-#include "../../config.h"
 
 #define TAPPING_TERM 200
-#define PREVENT_STUCK_MODIFIERS
 
 /* Use I2C or Serial, not both */
 

keyboards/lets_split/keymaps/pdl/keymap.c

@@ -22,7 +22,6 @@ along with this program. If not, see <http:https://www.gnu.org/licenses/>.
 
 #include QMK_KEYBOARD_H
 #include "pdl.c"
-extern keymap_config_t keymap_config;
 
 const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
  [_QWERTY] = KEYMAP_wrapper( \

keyboards/orthodox/keymaps/pdl/config.h

@@ -22,7 +22,6 @@ along with this program. If not, see <http:https://www.gnu.org/licenses/>.
 
 #pragma once
 
-#include "config_common.h"
 
 /* Use I2C or Serial, not both */
 

users/pdl/pdl.h

@@ -22,9 +22,6 @@ enum userspace_layer_codes {
 #define _CODING 7
 #define _FUNCTN 8
 
-// Fillers to make layering more clear
-#define _______ KC_TRNS
-#define XXXXXXX KC_NO
 
 #define MY_FESC LT(_FUNCTN, KC_ESC)
 #define MY_SSPC MT(MOD_RSFT, KC_SPC)