Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add userspace pdl and a handwired board #14199

Merged
merged 24 commits into from
Apr 13, 2022
Merged

Add userspace pdl and a handwired board #14199

merged 24 commits into from
Apr 13, 2022

Commits on Aug 18, 2021

  1. Add user pdl, keymap orthodox:pdl

    @pdl
    pdl committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    9f00f38 View commit details
    Browse the repository at this point in the history

  2. Add keymap lets_split:pdl

    @pdl
    pdl committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    7df9ed1 View commit details
    Browse the repository at this point in the history

  3. Add handwired keyboard 'reclined'

    @pdl
    pdl committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    4ac77a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2021

  1. Add layout foostan/cornelius:pdl

    @pdl
    pdl committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    ed448a7 View commit details
    Browse the repository at this point in the history

  2. Add combos to userspace pdl

    @pdl
    pdl committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    95cfe22 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. Updates to follow code style, depracations 

    This includes all of @drashna's suggestions on a pull request to include `pdl` layouts which can be accepted and added automatically. Suggestions given in text will require a separate commit.

Co-authored-by: Drashna Jaelre <[email protected]>
    @pdl @drashna
    pdl and drashna committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    40e4fe7 View commit details
    Browse the repository at this point in the history

  2. Add GPL copyright headers per @drashna

    @pdl
    pdl committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    d90b9be View commit details
    Browse the repository at this point in the history

  3. Always use LAYOUT_wrapper, not KEYMAP_wrapper, per @drashna

    @pdl
    pdl committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    1cf5ae4 View commit details
    Browse the repository at this point in the history

  4. Convert layers into enums per @drashna

    @pdl
    pdl committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    2469b14 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Apply fixes per @zvecr 

    As part of a pull request review, @zvecr suggested these two fixes.

Co-authored-by: Joel Challis <[email protected]>
    @pdl @zvecr
    pdl and zvecr committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    0f902c1 View commit details
    Browse the repository at this point in the history

  2. Replace KEYMAP with LAYOUT per @zvecr 

    Update keyboards/handwired/reclined/keymaps/default/keymap.c per @zvecr's suggestion on qmk#14199 pull request review

Co-authored-by: Joel Challis <[email protected]>
    @pdl @zvecr
    pdl and zvecr committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    5cbb885 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Have handwired/reclined use ortho_4x12 layout 

    As recommended by @drashna in code review for pull qmk#14199

Co-authored-by: Drashna Jaelre <[email protected]>
    @pdl @drashna
    pdl and drashna committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    2260952 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Fix handwired/reclined:pdl due to changes to using ortho_4x12 layout 

    For pull qmk#14199
    @pdl
    pdl committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    07b62fd View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2021

  1. Remove redundant declaration of LAYOUTS per @drashna 

    Co-authored-by: Drashna Jaelre <[email protected]>
    @pdl @drashna
    pdl and drashna committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    fdf8363 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Invoke userspace with USER_NAME instead of SRC 

    Implemented suggestions in code review by @fauxpark

Co-authored-by: Ryan <[email protected]>
    @pdl @fauxpark
    pdl and fauxpark committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    6cd1b55 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2021

  1. Style/comment changes per code review 

    As suggested by @fauxpark

Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
    @pdl @fauxpark @drashna
    3 people committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    5a01724 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2021

  1. Two more style/comment changes per code review 

    Per @fauxpark

Co-authored-by: Ryan <[email protected]>
    @pdl @fauxpark
    pdl and fauxpark committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    972cc63 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2021

  1. Add info.json for handwired/reclined

    @pdl
    pdl committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    953f2b7 View commit details
    Browse the repository at this point in the history

  2. Remove or comment out lines which info.json makes redundant in handwi… 

    …red/reclined
    @pdl
    pdl committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    ec5c705 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. Apply suggestions from code review per @fauxpark 

    I'm not fussy about where this stuff goes and happy to be guided on what the correct location for it is.

Co-authored-by: Ryan <[email protected]>
    @pdl @fauxpark
    pdl and fauxpark committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    b262200 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2022

  1. Remove redundant line per @noroadsleft 

    Co-authored-by: James Young <[email protected]>
    @pdl @noroadsleft
    pdl and noroadsleft committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    7f5cf61 View commit details
    Browse the repository at this point in the history

  2. Update keyboards/handwired/reclined/info.json per @noroadsleft 

    Co-authored-by: James Young <[email protected]>
    @pdl @noroadsleft
    pdl and noroadsleft committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    410e838 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review per @fauxpark 

    Co-authored-by: Ryan <[email protected]>
    @pdl @fauxpark
    pdl and fauxpark committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    7a4238a View commit details
    Browse the repository at this point in the history

  4. Add user keymap pdl for keyboard crkbd (corne)

    @pdl
    pdl committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    24f9066 View commit details
    Browse the repository at this point in the history