Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Quefrency layouts for QMK Configurator #13384

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

nooges
Copy link
Member

@nooges nooges commented Jun 29, 2021

Description

Add missing Quefrency layouts for QMK Configurator

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from noroadsleft and a team July 1, 2021 16:46
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@noroadsleft
Copy link
Member

Random thought:

I may need to rename the LAYOUT_60_iso and LAYOUT_65_iso macros later, because they actually won't play nicely with a Configurator feature I've long wanted: assigning default keymaps based on the layout macro name – the idea being preloading the keymaps from layouts/default/ into Configurator and having them able to be loaded for any board that supports the layout, but they wouldn't work here because of the split between the sides leading to extra keys.

This likely becomes a non-issue if Configurator gains to ability to do that based on the rules.mk LAYOUTS rule instead of the simply using the macro name.

@noroadsleft noroadsleft merged commit db7fd6c into qmk:master Jul 1, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 2, 2021
* qmk/develop: (25 commits)
  [Core] Unite half-duplex and full-duplex serial drivers (qmk#13081)
  Add missing Quefrency layouts for QMK Configurator (qmk#13384)
  [Keyboard] Adding Via support to the GON NerD60 (qmk#13395)
  [Keymap] Add haervig userspace and keymaps (qmk#13362)
  Convert Dip Switch callbacks to boolean functions (qmk#13399)
  Changed Yeehaw Default Keymap (qmk#13341)
  [Docs] update Japanese translation of other_eclipse.md (qmk#12776)
  update Japanese translation of config_options.md (qmk#12695)
  Translated 'feature_advanced_keycodes.md'. (qmk#12454)
  [Docs] Japanese translation of docs/keycodes_basic.md (qmk#11044)
  Illusion Rosa: correct layout macro names (qmk#13387)
  FJLabs Midway60: physically arrange layout macro and fix info.json data (qmk#13386)
  Sanctified Dystopia: physically arrange layout macro (qmk#13385)
  Updates for keymap: ut472/stefanopace (qmk#13370)
  [Keyboard] update debounce time on kint boards (qmk#13351)
  [Keymap] RGB Timeout added to userspace (qmk#13339)
  [Keyboard][Bug] Fix LED indicators on Skeletn87 (qmk#13335)
  [Keyboard] Pteron36, open source 3x5_3 supporting layout (qmk#13313)
  Drashna's split updates (qmk#13350)
  [Keymap] Create bingocaller keymap for DZ60RGB-ANSI (qmk#13311)
  ...
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
* Reformat info.json using Prettier

* Add missing layouts needed for QMK Configurators
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
* Reformat info.json using Prettier

* Add missing layouts needed for QMK Configurators
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
* Reformat info.json using Prettier

* Add missing layouts needed for QMK Configurators
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* Reformat info.json using Prettier

* Add missing layouts needed for QMK Configurators
@nooges nooges deleted the fix-quefrency-layout branch July 26, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants