Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Yeehaw Default Keymap #13341

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Changed Yeehaw Default Keymap #13341

merged 3 commits into from
Jul 1, 2021

Conversation

Tsquash
Copy link

@Tsquash Tsquash commented Jun 25, 2021

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Encoder keycodes were flipped on both via and default keymaps, this changes it so clockwise is volume up and counter clockwise is volume down. I also changed the macro url to https, and the via keymap now uses KC_TRNS instead of ____.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Jun 25, 2021
@drashna drashna requested a review from a team July 1, 2021 08:06
@fauxpark
Copy link
Member

fauxpark commented Jul 1, 2021

Thanks!

@fauxpark fauxpark merged commit c275828 into qmk:master Jul 1, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 2, 2021
* qmk/develop: (25 commits)
  [Core] Unite half-duplex and full-duplex serial drivers (qmk#13081)
  Add missing Quefrency layouts for QMK Configurator (qmk#13384)
  [Keyboard] Adding Via support to the GON NerD60 (qmk#13395)
  [Keymap] Add haervig userspace and keymaps (qmk#13362)
  Convert Dip Switch callbacks to boolean functions (qmk#13399)
  Changed Yeehaw Default Keymap (qmk#13341)
  [Docs] update Japanese translation of other_eclipse.md (qmk#12776)
  update Japanese translation of config_options.md (qmk#12695)
  Translated 'feature_advanced_keycodes.md'. (qmk#12454)
  [Docs] Japanese translation of docs/keycodes_basic.md (qmk#11044)
  Illusion Rosa: correct layout macro names (qmk#13387)
  FJLabs Midway60: physically arrange layout macro and fix info.json data (qmk#13386)
  Sanctified Dystopia: physically arrange layout macro (qmk#13385)
  Updates for keymap: ut472/stefanopace (qmk#13370)
  [Keyboard] update debounce time on kint boards (qmk#13351)
  [Keymap] RGB Timeout added to userspace (qmk#13339)
  [Keyboard][Bug] Fix LED indicators on Skeletn87 (qmk#13335)
  [Keyboard] Pteron36, open source 3x5_3 supporting layout (qmk#13313)
  Drashna's split updates (qmk#13350)
  [Keymap] Create bingocaller keymap for DZ60RGB-ANSI (qmk#13311)
  ...
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants