Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Valor #10079

Merged
merged 11 commits into from
Aug 19, 2020
Merged

Add Valor #10079

merged 11 commits into from
Aug 19, 2020

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Aug 18, 2020

Description

Add Valor Keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Add Valor Keyboard

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Aug 18, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few other things

  1. Copyright wilba 2 years ago?
  2. Not a massive fan of the board name being in the layout macro.

keyboards/xelus/valor/readme.md Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team August 18, 2020 23:41
fauxpark
fauxpark requested changes Aug 18, 2020
View reviewed changes
keyboards/xelus/valor/rules.mk Outdated Show resolved Hide resolved
@noroadsleft
Copy link
Member

2. Not a massive fan of the board name being in the layout macro.

100% agree.

@drashna drashna requested a review from a team August 19, 2020 02:30
noroadsleft
noroadsleft requested changes Aug 19, 2020
View reviewed changes
keyboards/xelus/valor/config.h Outdated Show resolved Hide resolved
@noroadsleft noroadsleft merged commit 79f080a into qmk:master Aug 19, 2020
@noroadsleft
Copy link
Member

Thanks!

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 20, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
4888f60 
* 'master' of https://github.com/qmk/qmk_firmware: (126 commits)
  [Keyboard] AJisai74 (qmk#10021)
  [Keyboard] HolySwitch Co Southpaw75 (qmk#10011)
  [Keymap] update dvorak_42_key keymaps for atreus and ergodox_ez: add VSCode shortcuts (qmk#10054)
  Fix typo in docs/feature_dynamic_macros (qmk#10085)
  [Keymap] VIA keymap for Cannonkeys Ortho60 (qmk#10086)
  [Keymap] xd60:shura30 (qmk#10089)
  Rename keyboards/handwired/zergo/keymap.c to keyboards/handwired/zergo/keymaps/default/keymap.c (qmk#10094)
  [Keymap] added dbroqua keymap for kbdfans/kbd6x (qmk#10072)
  [Keyboard] Vision keyboard by SatT (qmk#9768)
  60_ansi_arrows Community Layout; mrsendyyk keymaps for dz60 and maartenwut/eon65 (qmk#9993)
  [Keyboard] add Xelus Valor (qmk#10079)
  [Keyboard] Add support for keyboard 'Bolt' (qmk#10046)
  [Keymap] update kejadlen keymaps (qmk#9954)
  [Keymap] jotix_ortho_4x12_layout (qmk#10075)
  Changes to thevankeyboards/minivan:king keymap (qmk#10032)
  Refactor Adelais PCB (qmk#10069)
  [Keyboard] NK87 (qmk#9965)
  Update keymap for Keebio/iris4/rev4 (qmk#10062)
  Dawn60 update that breaks travis keyboard builds (qmk#10082)
  add VIA keymap for boardsource/3x4 (qmk#10043)
  ...
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@Xelus22 @nicocesar
[Keyboard] add Xelus Valor (qmk#10079)
85a1ef9 
* praxis avr

* rgb

* valor initial

* rgb limit

* readme update

* update rules.mk and include valor

* update readme

* Update rules.mk

* update readme and copyright + layout macro

* oops didnt save
@Xelus22 Xelus22 mentioned this pull request Sep 15, 2020
Merged
6 tasks
@Xelus22 Xelus22 deleted the valor branch March 24, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@zvecr zvecr zvecr requested changes

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Xelus22 @noroadsleft @drashna @fauxpark @zvecr @ridingqwerty