Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard: Southpaw75 #10011

Merged
merged 12 commits into from
Aug 20, 2020
Merged

New Keyboard: Southpaw75 #10011

merged 12 commits into from
Aug 20, 2020

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Aug 12, 2020 •
edited
Loading

Description

New keyboard from HolySwitch Co which is a 60% with a numpad on the left hand side.

Original QMK firmware code submitted by drewguy aka campingcampfire.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin added keyboard via Adds via keymap and/or updates keyboard for via support labels Aug 12, 2020
tzarc
tzarc requested changes Aug 12, 2020
View reviewed changes
keyboards/holyswitch/southpaw75/config.h Outdated Show resolved Hide resolved
@tzarc tzarc requested a review from a team August 12, 2020 03:50
@fauxpark
Copy link
Member

Dupe of #9844 ?

@mechmerlin
Copy link
Contributor Author

Dupe of #9844 ?

I think it's just a similarly named board. This is the Southpaw done in collaboration with Drew Guy and HolySwitch Co.

@fauxpark
Copy link
Member

fauxpark commented Aug 13, 2020 •
edited
Loading

The image in the readme is the same as that on the Holyswitch site :/
https://github.com/qmk/qmk_firmware/pull/9844/files#diff-deb12e387ce89cb4cba5b19501fc3fc4
Also the OP of 9844 is mentioned in the product description.

@fauxpark
Copy link
Member

Seems like there are two PCBs at play here, one which takes a Pro Micro-compatible board, and this one that I guess has an onboard 32U4. These should probably be combined into separate revisions of the same board.

@mechmerlin
Copy link
Contributor Author

Seems like there are two PCBs at play here, one which takes a Pro Micro-compatible board, and this one that I guess has an onboard 32U4. These should probably be combined into separate revisions of the same board.

This is very interesting, I have not been informed of this by the vendor, I'll reach out and have them clarify

@mechmerlin
Copy link
Contributor Author

Alright I reached out to DrewGuy the designer of this PCB.

This Southpaw75 with USB C is going to be sold exclusively in the United States and is being run by HolySwitch Co. The other Southpaw75 in PR #9844 is designed by Volvo and is going to be sold internationally through other vendors.

With that information, I think this PR is still valid. I will however append the README with this information. This one can be contained within the HolySwitch directory and the other southpaw75 can be contained within the generic keyboards directory. Any thoughts/opinions?

@kelvinhall05
Copy link
Contributor

Hi, figured I should clear something up :)

I created the Soutpaw75 and got Holyswitch as a US vendor. Drew was hired by Holyswitch to design a USB-C PCB with an integrated controller. While both this PCB and the original Pro Micro one should be compatible with the same QMK config, the matrix/controller pins are different so they're not compatible with the same firmware. I am in the process of adding the Pro Micro one to the configurator, and while that PR was still being reviewed, you added this PR for the Holyswitch PCB.

So, tl;dr, there are two different PCBs and both require their own QMK configs, and two separate PRs are open for each one.

Hopefully this clears things up lol. I do like the idea of having the USB-C one in a Holyswitch folder and mine in the generic keyboard directory.

@noroadsleft
Copy link
Member

@kelvinhall05 Thanks for clearing this up. I actually just merged your PR for the Pro Micro version about ten minutes ago, and I was quite confused when I saw the notification for this pull request.

@mechmerlin
Copy link
Contributor Author

I've added the necessary info the readme

noroadsleft
noroadsleft requested changes Aug 19, 2020
View reviewed changes
keyboards/holyswitch/southpaw75/config.h Outdated Show resolved Hide resolved
keyboards/holyswitch/southpaw75/info.json Outdated Show resolved Hide resolved
keyboards/holyswitch/southpaw75/info.json Outdated Show resolved Hide resolved
keyboards/holyswitch/southpaw75/southpaw75.h Outdated Show resolved Hide resolved
@noroadsleft noroadsleft requested a review from a team August 20, 2020 01:35
@noroadsleft noroadsleft merged commit ec7abc2 into qmk:master Aug 20, 2020
@noroadsleft
Copy link
Member

Thanks!

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 20, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
4888f60 
* 'master' of https://github.com/qmk/qmk_firmware: (126 commits)
  [Keyboard] AJisai74 (qmk#10021)
  [Keyboard] HolySwitch Co Southpaw75 (qmk#10011)
  [Keymap] update dvorak_42_key keymaps for atreus and ergodox_ez: add VSCode shortcuts (qmk#10054)
  Fix typo in docs/feature_dynamic_macros (qmk#10085)
  [Keymap] VIA keymap for Cannonkeys Ortho60 (qmk#10086)
  [Keymap] xd60:shura30 (qmk#10089)
  Rename keyboards/handwired/zergo/keymap.c to keyboards/handwired/zergo/keymaps/default/keymap.c (qmk#10094)
  [Keymap] added dbroqua keymap for kbdfans/kbd6x (qmk#10072)
  [Keyboard] Vision keyboard by SatT (qmk#9768)
  60_ansi_arrows Community Layout; mrsendyyk keymaps for dz60 and maartenwut/eon65 (qmk#9993)
  [Keyboard] add Xelus Valor (qmk#10079)
  [Keyboard] Add support for keyboard 'Bolt' (qmk#10046)
  [Keymap] update kejadlen keymaps (qmk#9954)
  [Keymap] jotix_ortho_4x12_layout (qmk#10075)
  Changes to thevankeyboards/minivan:king keymap (qmk#10032)
  Refactor Adelais PCB (qmk#10069)
  [Keyboard] NK87 (qmk#9965)
  Update keymap for Keebio/iris4/rev4 (qmk#10062)
  Dawn60 update that breaks travis keyboard builds (qmk#10082)
  add VIA keymap for boardsource/3x4 (qmk#10043)
  ...
@mechmerlin mechmerlin mentioned this pull request Aug 21, 2020
Merged
6 tasks
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@mechmerlin @nicocesar
[Keyboard] HolySwitch Co Southpaw75 (qmk#10011)
e0e9a3c 
* add in drewguy's code with a few additions to the keymap

* add VID and PID

* fixup defualt keymap

* add VIA keymap

* thanks to bigchimpo for reminding me to put an Fn key in the default keymap

* make sure we have the right gitugithub url for drew

* remove description as per PR checklist

* append readme with more information

* Update keyboards/holyswitch/southpaw75/config.h

* Update keyboards/holyswitch/southpaw75/info.json

* Update keyboards/holyswitch/southpaw75/southpaw75.h

* Update keyboards/holyswitch/southpaw75/info.json
@mechmerlin mechmerlin deleted the feature/southpaw75 branch January 26, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc requested changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mechmerlin @fauxpark @kelvinhall05 @noroadsleft @tzarc