Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA CI: disable security hardening flag #20487

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Mar 2, 2024

OpenSSL isn't compatible with /guard:cf flag so we omit it for now. Related: openssl/openssl#22554
Closes #20479.

OpenSSL isn't compatible with `/guard:cf` flag so we omit it for now.
Related: openssl/openssl#22554

Closes qbittorrent#20479.
@Chocobo1 Chocobo1 added the CI Issues/PRs related to CI label Mar 2, 2024
@Chocobo1 Chocobo1 requested a review from a team March 2, 2024 06:35
Copy link
Member

@glassez glassez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should comment them out instead of deleting them?

@Chocobo1
Copy link
Member Author

Chocobo1 commented Mar 2, 2024

Maybe you should comment them out instead of deleting them?

I thought of it but it seems Openssl isn't eager to resolve that problem so it will linger there for a long time.

@Chocobo1 Chocobo1 merged commit 71f1e6d into qbittorrent:master Mar 3, 2024
13 checks passed
@Chocobo1 Chocobo1 deleted the ci branch March 3, 2024 05:49
@qBittUser
Copy link

Can this be backported to v4.6.x?

Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this pull request Mar 26, 2024
OpenSSL isn't compatible with `/guard:cf` flag so we omit it for now.
Related: openssl/openssl#22554

Closes qbittorrent#20479.
PR qbittorrent#20487.
Chocobo1 added a commit that referenced this pull request Mar 28, 2024
OpenSSL isn't compatible with `/guard:cf` flag so we omit it for now.
Related: openssl/openssl#22554

Closes #20479.
PR #20487.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues/PRs related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.0 crashes when adding trackers
4 participants