-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0 crashes when adding trackers #20479
Comments
I'll attach a debugger then to see if I can catch a better stack trace |
Confirmed!
|
Some trackers are private, so I was a bit wary of adding them, but the passkeys have been removed, so there should be no problems. |
Can't reproduce with libtorrent 2.0.9. |
I can reproduce with 1.2.19/2.0.9/2.0.10 master builds by adding the trackers from my previous post. |
This comment was marked as resolved.
This comment was marked as resolved.
Cannot reproduce with master. |
The attached stack traces confuse. |
This may be specific to Windows & our CI builds
no magnet links, added the ubuntu 23.10 live server torrent file like OP.
It appears to be Boost/OpenSSL 3.2.x issue??
|
I just see the following sequence:
|
@xavier2k6, @stalkerok |
Just adding that one appears to be the tracker that's causing the crash, BTW qBittorrent can't be restarted unless the fastresume file is deleted. |
fastresume/associated torrent lbt 1.2.19 fastresume/associated torrent lbt 2.0.10 lbt 2.0.10 - Using SQLite database |
Yes, it looks like it's this tracker, but if you add it via http |
Download a build & test from below:
I believe it's an issue with OpenSSL from vcpkg |
The same build as in my comment above but using OpenSSL-3.2.1 still works w/o crash. |
@xavier2k6 |
Done & no crashing! 👍 Test Builds with all 3 https://github.com/xavier2k6/qBittorrent/actions/runs/8101919737 |
Confirmed, everything's fine now. |
@glassez similar problem, the system freezes and there was a bzod several times
|
(If you don't mind) I'll submit a patch in the weekend based on your findings, good job! 👍 |
@Chocobo1 Just an FYI
https://github.com/openssl/openssl/issues?q=is%3Aissue+is%3Aopen+Control+Flow+Guard |
@bulletproof2k Open a new ticket & provide as much detail as possible/reproducible steps etc. & any crash dumps/logs from eventwr related to qBittorrent |
OpenSSL isn't compatible with `/guard:cf` flag so we omit it for now. Related: openssl/openssl#22554 Closes qbittorrent#20479.
OpenSSL isn't compatible with `/guard:cf` flag so we omit it for now. Related: openssl/openssl#22554 Closes #20479. PR #20487.
OpenSSL isn't compatible with `/guard:cf` flag so we omit it for now. Related: openssl/openssl#22554 Closes qbittorrent#20479. PR qbittorrent#20487.
OpenSSL isn't compatible with `/guard:cf` flag so we omit it for now. Related: openssl/openssl#22554 Closes #20479. PR #20487.
qBittorrent & operating system versions
qBittorrent v5.0.0alpha1 (64-bit)
Qt: 6.5.2
Libtorrent: 1.2.19.0
Boost: 1.84.0
OpenSSL: 3.2.1
zlib: 1.3.1
What is the problem?
5.0 crashes when adding trackers
This does not happen always and not with all trackers. If the torrent is paused, there is no crash.
Tested on https://github.com/qbittorrent/qBittorrent/actions/runs/8065114663 and https://github.com/qbittorrent/qBittorrent/actions/runs/7847706279
Steps to reproduce
2024-02-28.14-10-49.mp4
Additional context
No response
Log(s) & preferences file(s)
qbittorrent.exe.2768.dmp
The text was updated successfully, but these errors were encountered: