Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix env.shape regex matches #1940

Merged
merged 1 commit into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/test_env.py
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ def test_mb_env_batch_lock(self, device, seed=0):
mb_env.step(td)

with pytest.raises(
RuntimeError, match=re.escape("Expected a tensordict with shape==env.shape")
RuntimeError, match=re.escape("Expected a tensordict with shape==env.batch_size")
):
mb_env.step(td_expanded)

Expand Down Expand Up @@ -1615,7 +1615,7 @@ def test_batch_locked(device):
_ = env.step(td)

with pytest.raises(
RuntimeError, match="Expected a tensordict with shape==env.shape, "
RuntimeError, match="Expected a tensordict with shape==env.batch_size, "
):
env.step(td_expanded)

Expand Down
4 changes: 2 additions & 2 deletions test/test_transforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -8231,7 +8231,7 @@ def test_batch_locked_transformed(device):
env.step(td)

with pytest.raises(
RuntimeError, match="Expected a tensordict with shape==env.shape, "
RuntimeError, match="Expected a tensordict with shape==env.batch_size, "
):
env.step(td_expanded)

Expand Down Expand Up @@ -8275,7 +8275,7 @@ def test_batch_unlocked_with_batch_size_transformed(device):
td_expanded = td.expand(2, 2).reshape(-1).to_tensordict()

with pytest.raises(
RuntimeError, match="Expected a tensordict with shape==env.shape, "
RuntimeError, match="Expected a tensordict with shape==env.batch_size, "
):
env.step(td_expanded)

Expand Down
Loading