Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix env.shape regex matches #1940

Merged
merged 1 commit into from
Feb 20, 2024
Merged

[BugFix] Fix env.shape regex matches #1940

merged 1 commit into from
Feb 20, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 20, 2024

No description provided.

Copy link

pytorch-bot bot commented Feb 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1940

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (21 Unrelated Failures)

As of commit 6f43ddc with merge base ca42794 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2024
@vmoens vmoens added bug Something isn't working Tests Incomplete or broken unit tests Suitable for minor Suitable to be integrated in minor release (no new feature) labels Feb 20, 2024
@vmoens vmoens merged commit 93885b6 into main Feb 20, 2024
31 of 52 checks passed
@vmoens vmoens deleted the fix-err-msg branch February 20, 2024 22:00
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 64.3084ms 63.5927ms 15.7251 Ops/s 14.4959 Ops/s $\textbf{\color{#35bf28}+8.48\%}$
test_sync 35.1610ms 34.6630ms 28.8492 Ops/s 28.2448 Ops/s $\color{#35bf28}+2.14\%$
test_async 60.7183ms 31.9746ms 31.2748 Ops/s 29.8800 Ops/s $\color{#35bf28}+4.67\%$
test_simple 0.5270s 0.4589s 2.1792 Ops/s 2.1874 Ops/s $\color{#d91a1a}-0.37\%$
test_transformed 0.6721s 0.6148s 1.6265 Ops/s 1.5978 Ops/s $\color{#35bf28}+1.80\%$
test_serial 1.5647s 1.5047s 0.6646 Ops/s 0.6595 Ops/s $\color{#35bf28}+0.77\%$
test_parallel 1.5256s 1.4631s 0.6835 Ops/s 0.7017 Ops/s $\color{#d91a1a}-2.60\%$
test_step_mdp_speed[True-True-True-True-True] 0.2010ms 21.8428μs 45.7816 KOps/s 46.8468 KOps/s $\color{#d91a1a}-2.27\%$
test_step_mdp_speed[True-True-True-True-False] 57.9090μs 13.3684μs 74.8034 KOps/s 76.2895 KOps/s $\color{#d91a1a}-1.95\%$
test_step_mdp_speed[True-True-True-False-True] 79.3090μs 12.8033μs 78.1046 KOps/s 79.8912 KOps/s $\color{#d91a1a}-2.24\%$
test_step_mdp_speed[True-True-True-False-False] 57.1470μs 7.7671μs 128.7486 KOps/s 133.8451 KOps/s $\color{#d91a1a}-3.81\%$
test_step_mdp_speed[True-True-False-True-True] 55.1440μs 23.3728μs 42.7848 KOps/s 44.0174 KOps/s $\color{#d91a1a}-2.80\%$
test_step_mdp_speed[True-True-False-True-False] 57.6480μs 14.6128μs 68.4334 KOps/s 70.1345 KOps/s $\color{#d91a1a}-2.43\%$
test_step_mdp_speed[True-True-False-False-True] 56.8060μs 14.1552μs 70.6454 KOps/s 73.5815 KOps/s $\color{#d91a1a}-3.99\%$
test_step_mdp_speed[True-True-False-False-False] 48.2400μs 9.0673μs 110.2869 KOps/s 113.9386 KOps/s $\color{#d91a1a}-3.20\%$
test_step_mdp_speed[True-False-True-True-True] 62.0360μs 24.7537μs 40.3980 KOps/s 41.6332 KOps/s $\color{#d91a1a}-2.97\%$
test_step_mdp_speed[True-False-True-True-False] 58.4990μs 16.1622μs 61.8726 KOps/s 64.4416 KOps/s $\color{#d91a1a}-3.99\%$
test_step_mdp_speed[True-False-True-False-True] 56.9170μs 14.1388μs 70.7273 KOps/s 73.1390 KOps/s $\color{#d91a1a}-3.30\%$
test_step_mdp_speed[True-False-True-False-False] 55.8040μs 9.1251μs 109.5878 KOps/s 113.5711 KOps/s $\color{#d91a1a}-3.51\%$
test_step_mdp_speed[True-False-False-True-True] 94.9070μs 25.7569μs 38.8246 KOps/s 39.8144 KOps/s $\color{#d91a1a}-2.49\%$
test_step_mdp_speed[True-False-False-True-False] 79.6590μs 17.1689μs 58.2447 KOps/s 60.6493 KOps/s $\color{#d91a1a}-3.96\%$
test_step_mdp_speed[True-False-False-False-True] 45.2650μs 15.2329μs 65.6473 KOps/s 67.5377 KOps/s $\color{#d91a1a}-2.80\%$
test_step_mdp_speed[True-False-False-False-False] 57.8690μs 10.2988μs 97.0988 KOps/s 100.2132 KOps/s $\color{#d91a1a}-3.11\%$
test_step_mdp_speed[False-True-True-True-True] 73.8880μs 24.8084μs 40.3089 KOps/s 41.4342 KOps/s $\color{#d91a1a}-2.72\%$
test_step_mdp_speed[False-True-True-True-False] 62.3860μs 16.0615μs 62.2606 KOps/s 63.9357 KOps/s $\color{#d91a1a}-2.62\%$
test_step_mdp_speed[False-True-True-False-True] 71.2530μs 16.4426μs 60.8175 KOps/s 62.3460 KOps/s $\color{#d91a1a}-2.45\%$
test_step_mdp_speed[False-True-True-False-False] 37.7910μs 10.2692μs 97.3785 KOps/s 99.8892 KOps/s $\color{#d91a1a}-2.51\%$
test_step_mdp_speed[False-True-False-True-True] 38.7320μs 26.3557μs 37.9424 KOps/s 38.8553 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[False-True-False-True-False] 52.1280μs 17.2297μs 58.0392 KOps/s 59.5168 KOps/s $\color{#d91a1a}-2.48\%$
test_step_mdp_speed[False-True-False-False-True] 44.5130μs 17.6834μs 56.5503 KOps/s 58.2692 KOps/s $\color{#d91a1a}-2.95\%$
test_step_mdp_speed[False-True-False-False-False] 54.0710μs 11.6145μs 86.0990 KOps/s 89.8684 KOps/s $\color{#d91a1a}-4.19\%$
test_step_mdp_speed[False-False-True-True-True] 93.8640μs 26.7800μs 37.3413 KOps/s 37.7973 KOps/s $\color{#d91a1a}-1.21\%$
test_step_mdp_speed[False-False-True-True-False] 51.2660μs 18.3363μs 54.5366 KOps/s 55.2874 KOps/s $\color{#d91a1a}-1.36\%$
test_step_mdp_speed[False-False-True-False-True] 75.9020μs 17.5380μs 57.0191 KOps/s 58.7347 KOps/s $\color{#d91a1a}-2.92\%$
test_step_mdp_speed[False-False-True-False-False] 40.8970μs 11.4824μs 87.0898 KOps/s 89.7320 KOps/s $\color{#d91a1a}-2.94\%$
test_step_mdp_speed[False-False-False-True-True] 91.8210μs 28.0769μs 35.6165 KOps/s 36.4844 KOps/s $\color{#d91a1a}-2.38\%$
test_step_mdp_speed[False-False-False-True-False] 43.9520μs 19.5932μs 51.0381 KOps/s 52.4702 KOps/s $\color{#d91a1a}-2.73\%$
test_step_mdp_speed[False-False-False-False-True] 53.2690μs 18.6471μs 53.6276 KOps/s 55.0033 KOps/s $\color{#d91a1a}-2.50\%$
test_step_mdp_speed[False-False-False-False-False] 40.2150μs 12.7394μs 78.4964 KOps/s 80.2795 KOps/s $\color{#d91a1a}-2.22\%$
test_values[generalized_advantage_estimate-True-True] 12.7313ms 9.3937ms 106.4544 Ops/s 105.2612 Ops/s $\color{#35bf28}+1.13\%$
test_values[vec_generalized_advantage_estimate-True-True] 36.4481ms 33.5555ms 29.8014 Ops/s 29.7606 Ops/s $\color{#35bf28}+0.14\%$
test_values[td0_return_estimate-False-False] 0.2563ms 0.1969ms 5.0780 KOps/s 4.7929 KOps/s $\textbf{\color{#35bf28}+5.95\%}$
test_values[td1_return_estimate-False-False] 26.1733ms 23.6513ms 42.2809 Ops/s 42.7132 Ops/s $\color{#d91a1a}-1.01\%$
test_values[vec_td1_return_estimate-False-False] 35.2658ms 33.6014ms 29.7607 Ops/s 29.7288 Ops/s $\color{#35bf28}+0.11\%$
test_values[td_lambda_return_estimate-True-False] 37.4282ms 34.2245ms 29.2188 Ops/s 29.9343 Ops/s $\color{#d91a1a}-2.39\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.5901ms 33.6238ms 29.7408 Ops/s 29.7374 Ops/s $\color{#35bf28}+0.01\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.1416ms 7.9756ms 125.3820 Ops/s 122.9996 Ops/s $\color{#35bf28}+1.94\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.7869ms 2.0816ms 480.4021 Ops/s 493.0012 Ops/s $\color{#d91a1a}-2.56\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4728ms 0.3515ms 2.8448 KOps/s 2.8384 KOps/s $\color{#35bf28}+0.22\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 46.2359ms 44.1215ms 22.6647 Ops/s 21.6345 Ops/s $\color{#35bf28}+4.76\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.8995ms 3.1236ms 320.1457 Ops/s 316.8417 Ops/s $\color{#35bf28}+1.04\%$
test_dqn_speed 80.4638ms 1.5559ms 642.7251 Ops/s 707.8837 Ops/s $\textbf{\color{#d91a1a}-9.20\%}$
test_ddpg_speed 3.6749ms 2.8744ms 347.9038 Ops/s 346.0783 Ops/s $\color{#35bf28}+0.53\%$
test_sac_speed 9.7680ms 9.0493ms 110.5062 Ops/s 108.9010 Ops/s $\color{#35bf28}+1.47\%$
test_redq_speed 14.7274ms 13.9211ms 71.8336 Ops/s 71.2319 Ops/s $\color{#35bf28}+0.84\%$
test_redq_deprec_speed 15.3451ms 14.6881ms 68.0822 Ops/s 65.9128 Ops/s $\color{#35bf28}+3.29\%$
test_td3_speed 9.7217ms 9.1279ms 109.5540 Ops/s 106.5843 Ops/s $\color{#35bf28}+2.79\%$
test_cql_speed 38.9268ms 38.0599ms 26.2744 Ops/s 26.0166 Ops/s $\color{#35bf28}+0.99\%$
test_a2c_speed 8.8408ms 8.1017ms 123.4305 Ops/s 122.5524 Ops/s $\color{#35bf28}+0.72\%$
test_ppo_speed 9.0388ms 8.5498ms 116.9613 Ops/s 116.1561 Ops/s $\color{#35bf28}+0.69\%$
test_reinforce_speed 7.3132ms 7.0725ms 141.3919 Ops/s 140.4074 Ops/s $\color{#35bf28}+0.70\%$
test_iql_speed 36.2333ms 34.3748ms 29.0911 Ops/s 29.0700 Ops/s $\color{#35bf28}+0.07\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.7750ms 3.4332ms 291.2700 Ops/s 304.6278 Ops/s $\color{#d91a1a}-4.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0396ms 0.5502ms 1.8174 KOps/s 1.8427 KOps/s $\color{#d91a1a}-1.37\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8205ms 0.5105ms 1.9589 KOps/s 1.9356 KOps/s $\color{#35bf28}+1.20\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.6576ms 3.3803ms 295.8283 Ops/s 310.6705 Ops/s $\color{#d91a1a}-4.78\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9141ms 0.5417ms 1.8459 KOps/s 1.8441 KOps/s $\color{#35bf28}+0.10\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9182ms 0.5157ms 1.9392 KOps/s 1.9534 KOps/s $\color{#d91a1a}-0.73\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.1705ms 3.5525ms 281.4911 Ops/s 294.6530 Ops/s $\color{#d91a1a}-4.47\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0726ms 0.6658ms 1.5020 KOps/s 1.4973 KOps/s $\color{#35bf28}+0.32\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7952ms 0.6296ms 1.5884 KOps/s 1.5653 KOps/s $\color{#35bf28}+1.48\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.5007ms 3.3097ms 302.1383 Ops/s 311.0062 Ops/s $\color{#d91a1a}-2.85\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8119ms 0.5489ms 1.8219 KOps/s 1.8167 KOps/s $\color{#35bf28}+0.29\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8315ms 0.5184ms 1.9291 KOps/s 1.9140 KOps/s $\color{#35bf28}+0.79\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.7010ms 3.3896ms 295.0195 Ops/s 312.0561 Ops/s $\textbf{\color{#d91a1a}-5.46\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6728ms 0.5348ms 1.8700 KOps/s 1.8449 KOps/s $\color{#35bf28}+1.36\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8106ms 0.5061ms 1.9757 KOps/s 1.9630 KOps/s $\color{#35bf28}+0.65\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.6360ms 3.4548ms 289.4515 Ops/s 298.3913 Ops/s $\color{#d91a1a}-3.00\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7874ms 0.6605ms 1.5141 KOps/s 1.4783 KOps/s $\color{#35bf28}+2.43\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0454ms 0.6348ms 1.5752 KOps/s 1.5546 KOps/s $\color{#35bf28}+1.32\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1273s 8.7857ms 113.8213 Ops/s 113.0699 Ops/s $\color{#35bf28}+0.66\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.6687ms 13.7821ms 72.5578 Ops/s 71.4661 Ops/s $\color{#35bf28}+1.53\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.8286ms 2.6505ms 377.2880 Ops/s 368.6845 Ops/s $\color{#35bf28}+2.33\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1087s 10.4296ms 95.8805 Ops/s 95.7044 Ops/s $\color{#35bf28}+0.18\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.2471ms 13.5764ms 73.6571 Ops/s 70.5804 Ops/s $\color{#35bf28}+4.36\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 4.9938ms 2.6601ms 375.9324 Ops/s 379.1473 Ops/s $\color{#d91a1a}-0.85\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1080s 10.9824ms 91.0550 Ops/s 90.8306 Ops/s $\color{#35bf28}+0.25\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.8025ms 14.1940ms 70.4522 Ops/s 69.1542 Ops/s $\color{#35bf28}+1.88\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 5.4604ms 2.9021ms 344.5797 Ops/s 337.8052 Ops/s $\color{#35bf28}+2.01\%$

Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1180s 0.1155s 8.6563 Ops/s 8.4461 Ops/s $\color{#35bf28}+2.49\%$
test_sync 0.1014s 0.1009s 9.9103 Ops/s 10.4226 Ops/s $\color{#d91a1a}-4.92\%$
test_async 0.1813s 91.7413ms 10.9002 Ops/s 10.9424 Ops/s $\color{#d91a1a}-0.39\%$
test_single_pixels 0.2089s 0.1447s 6.9100 Ops/s 7.4691 Ops/s $\textbf{\color{#d91a1a}-7.49\%}$
test_sync_pixels 83.7756ms 82.1678ms 12.1702 Ops/s 12.1203 Ops/s $\color{#35bf28}+0.41\%$
test_async_pixels 0.1546s 65.6154ms 15.2403 Ops/s 15.7763 Ops/s $\color{#d91a1a}-3.40\%$
test_simple 0.8191s 0.8182s 1.2222 Ops/s 1.2188 Ops/s $\color{#35bf28}+0.28\%$
test_transformed 1.0586s 1.0545s 0.9483 Ops/s 0.9576 Ops/s $\color{#d91a1a}-0.97\%$
test_serial 2.5370s 2.4880s 0.4019 Ops/s 0.4217 Ops/s $\color{#d91a1a}-4.69\%$
test_parallel 2.1453s 2.0911s 0.4782 Ops/s 0.4876 Ops/s $\color{#d91a1a}-1.92\%$
test_step_mdp_speed[True-True-True-True-True] 86.5510μs 32.8461μs 30.4450 KOps/s 30.0076 KOps/s $\color{#35bf28}+1.46\%$
test_step_mdp_speed[True-True-True-True-False] 38.5610μs 20.1575μs 49.6093 KOps/s 51.1620 KOps/s $\color{#d91a1a}-3.03\%$
test_step_mdp_speed[True-True-True-False-True] 36.6300μs 18.9423μs 52.7918 KOps/s 53.3582 KOps/s $\color{#d91a1a}-1.06\%$
test_step_mdp_speed[True-True-True-False-False] 28.9800μs 11.4477μs 87.3539 KOps/s 89.1773 KOps/s $\color{#d91a1a}-2.04\%$
test_step_mdp_speed[True-True-False-True-True] 57.0710μs 35.3296μs 28.3049 KOps/s 27.9294 KOps/s $\color{#35bf28}+1.34\%$
test_step_mdp_speed[True-True-False-True-False] 46.2100μs 22.2926μs 44.8578 KOps/s 46.3228 KOps/s $\color{#d91a1a}-3.16\%$
test_step_mdp_speed[True-True-False-False-True] 39.5010μs 20.9992μs 47.6208 KOps/s 48.0707 KOps/s $\color{#d91a1a}-0.94\%$
test_step_mdp_speed[True-True-False-False-False] 34.0900μs 13.3493μs 74.9103 KOps/s 75.6580 KOps/s $\color{#d91a1a}-0.99\%$
test_step_mdp_speed[True-False-True-True-True] 58.6610μs 37.9631μs 26.3414 KOps/s 26.6455 KOps/s $\color{#d91a1a}-1.14\%$
test_step_mdp_speed[True-False-True-True-False] 37.9700μs 23.9932μs 41.6784 KOps/s 42.4531 KOps/s $\color{#d91a1a}-1.82\%$
test_step_mdp_speed[True-False-True-False-True] 43.5300μs 21.0844μs 47.4285 KOps/s 48.5714 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[True-False-True-False-False] 36.0800μs 13.4409μs 74.3999 KOps/s 76.5492 KOps/s $\color{#d91a1a}-2.81\%$
test_step_mdp_speed[True-False-False-True-True] 64.8310μs 39.6847μs 25.1986 KOps/s 25.4160 KOps/s $\color{#d91a1a}-0.86\%$
test_step_mdp_speed[True-False-False-True-False] 46.8910μs 25.8251μs 38.7220 KOps/s 39.3186 KOps/s $\color{#d91a1a}-1.52\%$
test_step_mdp_speed[True-False-False-False-True] 41.2610μs 22.8006μs 43.8584 KOps/s 44.6610 KOps/s $\color{#d91a1a}-1.80\%$
test_step_mdp_speed[True-False-False-False-False] 36.1700μs 15.2527μs 65.5623 KOps/s 66.3984 KOps/s $\color{#d91a1a}-1.26\%$
test_step_mdp_speed[False-True-True-True-True] 61.9200μs 37.8333μs 26.4317 KOps/s 26.2673 KOps/s $\color{#35bf28}+0.63\%$
test_step_mdp_speed[False-True-True-True-False] 70.4410μs 24.3653μs 41.0419 KOps/s 42.5721 KOps/s $\color{#d91a1a}-3.59\%$
test_step_mdp_speed[False-True-True-False-True] 46.0810μs 25.0952μs 39.8482 KOps/s 40.0017 KOps/s $\color{#d91a1a}-0.38\%$
test_step_mdp_speed[False-True-True-False-False] 32.0610μs 15.3359μs 65.2064 KOps/s 66.7787 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[False-True-False-True-True] 65.9210μs 39.6624μs 25.2128 KOps/s 24.8937 KOps/s $\color{#35bf28}+1.28\%$
test_step_mdp_speed[False-True-False-True-False] 45.9510μs 26.2150μs 38.1462 KOps/s 39.2409 KOps/s $\color{#d91a1a}-2.79\%$
test_step_mdp_speed[False-True-False-False-True] 51.1900μs 27.0574μs 36.9585 KOps/s 37.2165 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[False-True-False-False-False] 45.4010μs 17.2013μs 58.1353 KOps/s 58.8886 KOps/s $\color{#d91a1a}-1.28\%$
test_step_mdp_speed[False-False-True-True-True] 67.6010μs 42.0849μs 23.7615 KOps/s 24.1653 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[False-False-True-True-False] 54.9710μs 28.3779μs 35.2387 KOps/s 36.3288 KOps/s $\color{#d91a1a}-3.00\%$
test_step_mdp_speed[False-False-True-False-True] 57.5210μs 27.1359μs 36.8516 KOps/s 37.4953 KOps/s $\color{#d91a1a}-1.72\%$
test_step_mdp_speed[False-False-True-False-False] 37.7100μs 17.2052μs 58.1219 KOps/s 59.4839 KOps/s $\color{#d91a1a}-2.29\%$
test_step_mdp_speed[False-False-False-True-True] 67.0810μs 42.8789μs 23.3215 KOps/s 23.7935 KOps/s $\color{#d91a1a}-1.98\%$
test_step_mdp_speed[False-False-False-True-False] 46.7610μs 29.5567μs 33.8332 KOps/s 34.2874 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[False-False-False-False-True] 47.7110μs 28.3947μs 35.2178 KOps/s 34.9379 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[False-False-False-False-False] 33.2800μs 18.9358μs 52.8101 KOps/s 53.8071 KOps/s $\color{#d91a1a}-1.85\%$
test_values[generalized_advantage_estimate-True-True] 26.4049ms 25.8620ms 38.6667 Ops/s 40.7721 Ops/s $\textbf{\color{#d91a1a}-5.16\%}$
test_values[vec_generalized_advantage_estimate-True-True] 94.0078ms 3.4444ms 290.3237 Ops/s 301.7435 Ops/s $\color{#d91a1a}-3.78\%$
test_values[td0_return_estimate-False-False] 98.7610μs 61.1215μs 16.3608 KOps/s 16.6106 KOps/s $\color{#d91a1a}-1.50\%$
test_values[td1_return_estimate-False-False] 56.1938ms 54.3021ms 18.4155 Ops/s 19.1841 Ops/s $\color{#d91a1a}-4.01\%$
test_values[vec_td1_return_estimate-False-False] 2.0724ms 1.7629ms 567.2518 Ops/s 569.4799 Ops/s $\color{#d91a1a}-0.39\%$
test_values[td_lambda_return_estimate-True-False] 91.7551ms 90.0060ms 11.1104 Ops/s 12.0363 Ops/s $\textbf{\color{#d91a1a}-7.69\%}$
test_values[vec_td_lambda_return_estimate-True-False] 3.8395ms 1.8004ms 555.4268 Ops/s 557.7772 Ops/s $\color{#d91a1a}-0.42\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.8780ms 25.1743ms 39.7230 Ops/s 43.2637 Ops/s $\textbf{\color{#d91a1a}-8.18\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8943ms 0.7017ms 1.4251 KOps/s 1.4433 KOps/s $\color{#d91a1a}-1.26\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7375ms 0.6529ms 1.5317 KOps/s 1.5522 KOps/s $\color{#d91a1a}-1.33\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4823ms 1.4509ms 689.2389 Ops/s 691.3095 Ops/s $\color{#d91a1a}-0.30\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9586ms 0.6750ms 1.4815 KOps/s 1.5029 KOps/s $\color{#d91a1a}-1.42\%$
test_dqn_speed 3.8336ms 1.4711ms 679.7784 Ops/s 680.8885 Ops/s $\color{#d91a1a}-0.16\%$
test_ddpg_speed 3.0607ms 2.8508ms 350.7752 Ops/s 355.8651 Ops/s $\color{#d91a1a}-1.43\%$
test_sac_speed 8.8407ms 8.1943ms 122.0363 Ops/s 123.8678 Ops/s $\color{#d91a1a}-1.48\%$
test_redq_speed 10.9755ms 10.1457ms 98.5638 Ops/s 98.0125 Ops/s $\color{#35bf28}+0.56\%$
test_redq_deprec_speed 11.8586ms 11.1718ms 89.5107 Ops/s 92.7900 Ops/s $\color{#d91a1a}-3.53\%$
test_td3_speed 8.4859ms 8.2510ms 121.1972 Ops/s 123.7261 Ops/s $\color{#d91a1a}-2.04\%$
test_cql_speed 26.6503ms 25.6149ms 39.0398 Ops/s 39.6867 Ops/s $\color{#d91a1a}-1.63\%$
test_a2c_speed 6.1853ms 5.5938ms 178.7685 Ops/s 185.2241 Ops/s $\color{#d91a1a}-3.49\%$
test_ppo_speed 6.2354ms 5.9029ms 169.4089 Ops/s 174.5985 Ops/s $\color{#d91a1a}-2.97\%$
test_reinforce_speed 5.7463ms 4.6069ms 217.0669 Ops/s 226.4628 Ops/s $\color{#d91a1a}-4.15\%$
test_iql_speed 0.1018s 21.1969ms 47.1767 Ops/s 52.2245 Ops/s $\textbf{\color{#d91a1a}-9.67\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.9162ms 3.7475ms 266.8469 Ops/s 268.8847 Ops/s $\color{#d91a1a}-0.76\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 91.2896ms 0.6450ms 1.5504 KOps/s 1.7711 KOps/s $\textbf{\color{#d91a1a}-12.46\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8025ms 0.5419ms 1.8455 KOps/s 1.8645 KOps/s $\color{#d91a1a}-1.02\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.0664ms 3.7683ms 265.3723 Ops/s 266.7729 Ops/s $\color{#d91a1a}-0.52\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7257ms 0.5647ms 1.7708 KOps/s 1.7930 KOps/s $\color{#d91a1a}-1.24\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7112ms 0.5371ms 1.8619 KOps/s 1.8853 KOps/s $\color{#d91a1a}-1.24\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.0130ms 3.8601ms 259.0626 Ops/s 257.6528 Ops/s $\color{#35bf28}+0.55\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8990ms 0.6993ms 1.4300 KOps/s 1.3078 KOps/s $\textbf{\color{#35bf28}+9.34\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 91.9445ms 0.7477ms 1.3375 KOps/s 1.5210 KOps/s $\textbf{\color{#d91a1a}-12.07\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.8689ms 3.7274ms 268.2858 Ops/s 266.5803 Ops/s $\color{#35bf28}+0.64\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6904ms 0.5701ms 1.7541 KOps/s 1.7677 KOps/s $\color{#d91a1a}-0.77\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7357ms 0.5427ms 1.8427 KOps/s 1.8604 KOps/s $\color{#d91a1a}-0.95\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9541ms 3.7631ms 265.7378 Ops/s 263.7816 Ops/s $\color{#35bf28}+0.74\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7616ms 0.5641ms 1.7728 KOps/s 1.7989 KOps/s $\color{#d91a1a}-1.45\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6718ms 0.5387ms 1.8564 KOps/s 1.5990 KOps/s $\textbf{\color{#35bf28}+16.10\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.9480ms 3.8548ms 259.4158 Ops/s 256.1133 Ops/s $\color{#35bf28}+1.29\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8104ms 0.6980ms 1.4326 KOps/s 1.4546 KOps/s $\color{#d91a1a}-1.51\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8403ms 0.6718ms 1.4886 KOps/s 1.5101 KOps/s $\color{#d91a1a}-1.43\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1041s 11.2173ms 89.1477 Ops/s 89.5020 Ops/s $\color{#d91a1a}-0.40\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.7386ms 16.4379ms 60.8351 Ops/s 61.7865 Ops/s $\color{#d91a1a}-1.54\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 5.2910ms 3.0691ms 325.8331 Ops/s 335.9584 Ops/s $\color{#d91a1a}-3.01\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 99.4931ms 11.0360ms 90.6126 Ops/s 89.5864 Ops/s $\color{#35bf28}+1.15\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.7982ms 16.5038ms 60.5922 Ops/s 61.6498 Ops/s $\color{#d91a1a}-1.72\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.5193ms 3.0443ms 328.4868 Ops/s 332.4961 Ops/s $\color{#d91a1a}-1.21\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1009s 9.5697ms 104.4964 Ops/s 105.2005 Ops/s $\color{#d91a1a}-0.67\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.7044ms 16.4776ms 60.6885 Ops/s 54.6265 Ops/s $\textbf{\color{#35bf28}+11.10\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.7044ms 3.3564ms 297.9364 Ops/s 300.6424 Ops/s $\color{#d91a1a}-0.90\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Suitable for minor Suitable to be integrated in minor release (no new feature) Tests Incomplete or broken unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants