Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmarking] Add join_results.py #129202

Closed
wants to merge 3 commits into from
Closed

Conversation

jansel
Copy link
Contributor

@jansel jansel commented Jun 21, 2024

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129202

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6415314 with merge base 9108b74 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
@jansel jansel changed the title [wip] merge_csv tool [benchmarking] Add join_results.py Jul 4, 2024
[ghstack-poisoned]
jansel added a commit that referenced this pull request Jul 4, 2024
ghstack-source-id: 83255fe9afb3a9e6b49a48eb3fdded1f8cf6e4da
Pull Request resolved: #129202
@jansel jansel added the topic: not user facing topic category label Jul 4, 2024
@jansel jansel marked this pull request as ready for review July 4, 2024 22:04
@jansel
Copy link
Contributor Author

jansel commented Jul 5, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 5, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Copy link
Contributor

@shunting314 shunting314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tool to merge results for different backends.

One more thing that's useful is maybe allow args.field to be a csv since we may want to compare not only speedup but also other metrics like compilation_time across backends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants