Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[halide-backend] Add GPU support #127506

Closed
wants to merge 32 commits into from
Closed

[halide-backend] Add GPU support #127506

wants to merge 32 commits into from

Conversation

jansel
Copy link
Contributor

@jansel jansel commented May 30, 2024 •
edited
Loading

This was referenced May 30, 2024
Closed
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127506

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit d1dd5df with merge base bc8883a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jansel added a commit that referenced this pull request May 30, 2024
@jansel
[halide-backend] Add GPU support
dcf1768 
ghstack-source-id: f916552234a824b197d1601e8b172899b6436d43
Pull Request resolved: #127506
@jansel
Update on "[halide-backend] Add GPU support"
5202a1d 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
jansel added a commit that referenced this pull request Jun 1, 2024
@jansel
[halide-backend] Add GPU support
89bc995 
ghstack-source-id: 7099c49b82a23722c6402afb786cf753cfe0e37a
Pull Request resolved: #127506
@jansel
Update on "[halide-backend] Add GPU support"
c80a99f 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
jansel added a commit that referenced this pull request Jun 2, 2024
@jansel
[halide-backend] Add GPU support
4aff375 
ghstack-source-id: df5d1c890e0555fd2ac1bcc41208807777980dba
Pull Request resolved: #127506
@jansel
Update on "[halide-backend] Add GPU support"
59bf967 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@jansel jansel mentioned this pull request Jun 3, 2024
Closed
jansel added a commit that referenced this pull request Jun 3, 2024
@jansel
[halide-backend] Add GPU support
84525ea 
ghstack-source-id: 6ea4d6353ee87452cb2976823c7f5152cb7ce3db
Pull Request resolved: #127506
@jansel
Update on "[halide-backend] Add GPU support"
8ecd793 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
This was referenced Jun 7, 2024
Closed
Closed
jansel added a commit that referenced this pull request Jun 7, 2024
@jansel
[halide-backend] Add GPU support
40a2e64 
ghstack-source-id: 51a5eae1047d818867164856540fe539393a4e3b
Pull Request resolved: #127506
@jansel
Update on "[halide-backend] Add GPU support"
d3576a5 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
jansel added a commit that referenced this pull request Jun 8, 2024
@jansel
[halide-backend] Add GPU support
bfc94cf 
ghstack-source-id: 96bd42bac39a1d70227f987c78f127bc4fa75094
Pull Request resolved: #127506
@jansel
Update on "[halide-backend] Add GPU support"
bf8b486 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@jansel
Update on "[halide-backend] Add GPU support"
3b62dec 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
jansel added a commit that referenced this pull request Jun 8, 2024
@jansel
[halide-backend] Add GPU support
d66f6e8 
ghstack-source-id: f3c533540f1048ef588dc097b5f95114a3e462b7
Pull Request resolved: #127506
@jansel
Update
4a799fd 
[ghstack-poisoned]
@jansel
Update
106c6a4 
[ghstack-poisoned]
@jansel
Update
83a6bae 
[ghstack-poisoned]
shunting314
shunting314 approved these changes Jun 21, 2024
View reviewed changes
torch/_inductor/codegen/common.py
register_backend_for_device(
"cuda",
CUDACombinedScheduling,
lambda *args, **kwargs: cuda_backends[config.cuda_backend](*args, **kwargs),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does simply cuda_backends[config.cuda_backend] without the lambda wrapper not work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails if you change the config value at runtime.

@jansel
Update
9f93242 
[ghstack-poisoned]
@jansel
Update
de6a5c8 
[ghstack-poisoned]
@jansel
Update
e19fff3 
[ghstack-poisoned]
@jansel
Update
de6fbab 
[ghstack-poisoned]
@jansel
Update
9715754 
[ghstack-poisoned]
@jansel jansel mentioned this pull request Jun 22, 2024
Draft
@jansel
Update
4ea0ccf 
[ghstack-poisoned]
This was referenced Jun 23, 2024
Closed
Closed
@jansel
Copy link
Contributor Author

jansel commented Jun 23, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 23, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-14)

Details for Dev Infra team Raised by workflow job

OnlyFor pushed a commit to OnlyFor/pytorch that referenced this pull request Jun 23, 2024
@jansel
[halide-backend] Add GPU support
5d117d5 
ghstack-source-id: 05392d368ee00e3fd793846a1a8ba207adcf3556
Pull Request resolved: pytorch#127506
@jansel
Update
042d8c2 
[ghstack-poisoned]
@jansel
Update
08b8c5d 
[ghstack-poisoned]
@jansel
Update
491ef5b 
[ghstack-poisoned]
@jansel
Update
7359801 
[ghstack-poisoned]
@jansel
Update
d1dd5df 
[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Jun 29, 2024
@jansel @pytorchmergebot
[halide-backend] Enable bfloat16 support (#129036)
4cb8cb0 
Requires halide/Halide#8255

Pull Request resolved: #129036
Approved by: https://github.com/shunting314, https://github.com/eellison
ghstack dependencies: #126417, #129025, #129026, #127506
pytorchmergebot pushed a commit that referenced this pull request Jun 29, 2024
@jansel @pytorchmergebot
[halide-backend] Disable split reductions for Halide (#129320)
a18eb65 
In theory Halide doesn't need the split reduction stuff we do for Triton since it can generate multiple kernels.

Pull Request resolved: #129320
Approved by: https://github.com/shunting314, https://github.com/eellison
ghstack dependencies: #126417, #129025, #129026, #127506, #129036
pytorchmergebot pushed a commit that referenced this pull request Jun 29, 2024
@jansel @pytorchmergebot
[halide-backend] Support manual schedules (#129321)
9ae78a5 
Currently using this for some by-hand hacking, but might need to implement our own scheduler later.

Pull Request resolved: #129321
Approved by: https://github.com/shunting314
ghstack dependencies: #126417, #129025, #129026, #127506, #129036, #129320
@github-actions github-actions bot deleted the gh/jansel/346/head branch July 31, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

@shunting314 shunting314 shunting314 approved these changes

@FindHao FindHao Awaiting requested review from FindHao

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: inductor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jansel @pytorchmergebot @eellison @shunting314