-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecated][inductor] switch CppCodeCache to new cpp_builder. (take 2) #129144
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129144
Note: Links to docs will display an error until the docs builds have been completed. ❌ 17 New Failures, 32 Unrelated FailuresAs of commit d282bc0 with merge base 93a33bf ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Successfully rebased |
992de3d
to
d26c975
Compare
@pytorchmergebot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Hi @desertfire could you please help on test it on |
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@pytorchmergebot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Rebase failed due to Command
Raised by https://github.com/pytorch/pytorch/actions/runs/9627595117 |
revert unrelated changes.
…uhancn/pytorch into xu_switch_to_new_cpp_builder_2
@pytorchmergebot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Rebase failed due to Command
Raised by https://github.com/pytorch/pytorch/actions/runs/9627657810 |
hi @desertfire , I tried to fix issue by this commit: 1dd0d10 |
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Original PRs is damaged by confilct and rebase: #128303, #129144 This PR just switch `HalideCodeCache` to new cpp_builder and it is not `fb_code` related. It can merge without `fb_code` test. Let's land this change firstly. Pull Request resolved: #129441 Approved by: https://github.com/jgong5, https://github.com/desertfire
The old one is damaged on Pre CI: #128303, this is new one.
This PR is the implemention of #124245 step 2.1
CppCodeCache
to new CPP builder.AotCodeCompiler
to new CPP builder.HalideCodeCache
to new CPP builder.TODO:
Current still need to optimize code structure and circle import. I will do this work in further PR. I have did the exploration: #128330
cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @vladimir-aubrecht @iremyux @Blackhex @cristianPanaite @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @ezyang @anijain2305 @chauhang @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire