-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecated][inductor] switch CppCodeCache to new cpp_builder. #128303
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128303
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (15 Unrelated Failures)As of commit 033835f with merge base 5fba5d8 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
@pytorchbot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Successfully rebased |
0b6b788
to
ac22619
Compare
8504f7f
to
80d49be
Compare
246ffb1
to
891cf9e
Compare
internal-external out of sync. Will need to wait for a while. |
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hi @desertfire , could you please let me know the import status? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the unused or commented out code?
restructure code to solve it in next PR, let's land it firstly.
…129059) I have run the first inductor case on Windows base on the exploration code: #128330 Due to some fundamental PR still need pass `fb_code`: #128303 This PR would land some part of exploration code: 1. Fix Windows python module ext type: pyd. 2. Add function export declaration for Windows. Pull Request resolved: #129059 Approved by: https://github.com/jgong5, https://github.com/jansel
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@desertfire Please help on validate new two fix in
|
@pytorchmergebot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Rebase failed due to Command
Raised by https://github.com/pytorch/pytorch/actions/runs/9599403273 |
@desertfire this PR seems damaged, please move to new one: #129144 |
Original PRs is damaged by confilct and rebase: #128303, #129144 This PR just switch `HalideCodeCache` to new cpp_builder and it is not `fb_code` related. It can merge without `fb_code` test. Let's land this change firstly. Pull Request resolved: #129441 Approved by: https://github.com/jgong5, https://github.com/desertfire
This PR is the implemention of #124245 step 2.1
CppCodeCache
to new CPP builder.AotCodeCompiler
to new CPP builder.HalideCodeCache
to new CPP builder.TODO:
Current still need to optimize code structure and circle import. I will do this work in further PR. I have did the exploration: #128330
cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @vladimir-aubrecht @iremyux @Blackhex @cristianPanaite @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang