Relax constraints for creating a GenericContextWrappingVariable

[guilhermeleobas]

Stack from ghstack (oldest at bottom):

• Let dynamo inline functional_call #128646
• wrap self.call_function(...) in try finally block to undo changes to self.kw_names #130490
• -> Relax constraints for creating a GenericContextWrappingVariable #129091

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129091

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 66a1370 with merge base 316c0d3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[guilhermeleobas]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[pytorchmergebot]

Successfully rebased gh/guilhermeleobas/55/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/129091)

[zou3519]

Can we turn on fullgraph=True on line 877?

[yanboliang]

left one comment, otherwise, looks good!

[guilhermeleobas]

@zou3519, with these changes, some contexts managers from pytest/unittest are now reaching this elif statement, rather than becoming a graph break. The problematic ones are failing because they check if the test raises a specific exception (assert_raises, assertRaisesRegexHighlighted) but dynamo changes the exception.

With that said, I had to add more than 100 files to dynamo_expected_failure folder. Would it be ok if I just ignore those context managers?

elif (
    issubclass(type(self.value), type)
    and hasattr(
        self.value, "__enter__"
    )  # TODO(voz): These can invoke user code!
    and hasattr(
        self.value, "__exit__"
    )  # TODO(voz): These can invoke user code!
    and self.value.__new__ == object.__new__
    and SideEffects.cls_supports_mutation_side_effects(self.value)
    and self.source is not None
    and self.value not in (assert_raises, assertRaisesRegexHighlight)  # <----- this
):

[guilhermeleobas]

My motivation for this change is as while dynamo cannot handle those context managers, the test might be composed of other compilable code that has value. Adding the test to dynamo_expected_failure may hide bugs that we don't catch because the test will be ignored.

[zou3519]

@yanboliang is there a way to mark a single API from e.g. pytest as skipped?

[zou3519]

NB: I'm fine with this, we just need to skip 3 decorators here