-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let dynamo inline functional_call #128646
Let dynamo inline functional_call #128646
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128646
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6ac6c73 with merge base bd1a29b (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: d203d828db3f44d632ad470a277a8e1cf9a7cb58 Pull Request resolved: #128646
ghstack-source-id: 30bda4280b96db021c98f3ca872d058ac313f953 Pull Request resolved: #128646
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
ghstack-source-id: 1c2db72ebecb7ab238f33940e7e4db3615ea0909 Pull Request resolved: #128646
ghstack-source-id: bcbf111becf2316856b73a39ac563c22aba6a815 Pull Request resolved: #128646
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Rebase failed due to Command '['ghstack']' returned non-zero exit status 1. |
ghstack-source-id: 1667f11a4ab81e9f8b890b045bb988408c44b000 Pull Request resolved: #128646
ghstack-source-id: 743f5318fcf75999278945af64ba683c821c7d67 Pull Request resolved: #128646
ghstack-source-id: f27c99eae21eca0b40103a0ee0001ab34c214950 Pull Request resolved: #128646
@pytorchbot rebase |
ghstack-source-id: 97e4d80b72de8f180a5371625ed2f4f87ccc5fd3 Pull Request resolved: #128646
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -m "the newly added test dynamo/test_higher_order_ops.py::FuncTorchHigherOrderOpTests::test_functional_call_sequential_params_and_buffers GH job link HUD commit link is broken, probably a landrace since it passed on PR" -c landrace |
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 5aab1ac. Reverted #128646 on behalf of https://github.com/clee2000 due to the newly added test dynamo/test_higher_order_ops.py::FuncTorchHigherOrderOpTests::test_functional_call_sequential_params_and_buffers [GH job link](https://github.com/pytorch/pytorch/actions/runs/10147452270/job/28058682000) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/5aab1acc84ff4a4374c9ddd179be48b07c6c8a74) is broken, probably a landrace since it passed on PR ([comment](#128646 (comment)))
@guilhermeleobas your PR has been successfully reverted. |
ghstack-source-id: 0e919af09d74f4e9368ca92c55ce4eb14a1abae0 Pull Request resolved: #128646
Issue seems to be fixed. I'll try to merge it again in a bit |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
cc @zou3519 @Chillee @samdow @kshitij12345 @janeyx99 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames