-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload release tag source code to s3 #128842
Conversation
Looks good. How users will be able to access these artifacts ? |
The artifacts can be downloaded from the GHA page for the workflow run or on s3 from https://us-east-1.console.aws.amazon.com/s3/buckets/pytorch?region=us-east-1&bucketType=general&prefix=source_code/test/&showversions=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Lets validate the upload of this package
Similar to: https://github.com/pytorch/pytorch/blob/main/.github/workflows/docker-release.yml
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider replacing release cut
with say release tag
@pytorchbot merge -f "no trunk needed" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot cherry-pick --help |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot cherry-pick --onto release/2.4 -c release |
Upload tarball containing source code to s3 for release tags Can be found here https://us-east-1.console.aws.amazon.com/s3/buckets/pytorch?region=us-east-1&bucketType=general&prefix=source_code/test/&showversions=false D58695048 for adding permissions to allow uploading to the s3 folder Pull Request resolved: #128842 Approved by: https://github.com/atalman, https://github.com/malfet (cherry picked from commit 795db80)
Cherry picking #128842The cherry pick PR is at #129600 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Upload release tag source code to s3 (#128842) Upload tarball containing source code to s3 for release tags Can be found here https://us-east-1.console.aws.amazon.com/s3/buckets/pytorch?region=us-east-1&bucketType=general&prefix=source_code/test/&showversions=false D58695048 for adding permissions to allow uploading to the s3 folder Pull Request resolved: #128842 Approved by: https://github.com/atalman, https://github.com/malfet (cherry picked from commit 795db80) Co-authored-by: Catherine Lee <[email protected]>
Upload tarball containing source code to s3 for release tags
Can be found here https://us-east-1.console.aws.amazon.com/s3/buckets/pytorch?region=us-east-1&bucketType=general&prefix=source_code/test/&showversions=false
D58695048 for adding permissions to allow uploading to the s3 folder