Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload release tag source code to s3 #128842

Closed
wants to merge 15 commits into from
Closed

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jun 17, 2024

Upload tarball containing source code to s3 for release tags

Can be found here https://us-east-1.console.aws.amazon.com/s3/buckets/pytorch?region=us-east-1&bucketType=general&prefix=source_code/test/&showversions=false

D58695048 for adding permissions to allow uploading to the s3 folder

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 17, 2024
Copy link

pytorch-bot bot commented Jun 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128842

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (12 Unrelated Failures)

As of commit 5e20e92 with merge base 2a41fc0 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman
Copy link
Contributor

atalman commented Jun 17, 2024

Looks good. How users will be able to access these artifacts ?

@clee2000
Copy link
Contributor Author

clee2000 commented Jun 17, 2024

Looks good. How users will be able to access these artifacts ?

The artifacts can be downloaded from the GHA page for the workflow run or on s3 from https://us-east-1.console.aws.amazon.com/s3/buckets/pytorch?region=us-east-1&bucketType=general&prefix=source_code/test/&showversions=false

@clee2000 clee2000 marked this pull request as ready for review June 17, 2024 19:41
@clee2000 clee2000 requested a review from a team as a code owner June 17, 2024 19:41
@clee2000 clee2000 changed the title Upload release branch artifacts to github actions Upload release branch source code to github actions Jun 17, 2024
@clee2000 clee2000 changed the title Upload release branch source code to github actions Upload release cut source code to s3 Jun 17, 2024
@clee2000 clee2000 temporarily deployed to sourcecode-upload June 18, 2024 19:13 — with GitHub Actions Inactive
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Lets validate the upload of this package

@atalman
Copy link
Contributor

atalman commented Jun 26, 2024

Similar to: https://github.com/pytorch/pytorch/blob/main/.github/workflows/docker-release.yml
we need to run it on:

  push:
    tags:
      # Final Release tags look like: v1.11.0
      - v[0-9]+.[0-9]+.[0-9]+
      # Release candidate tags look like: v1.11.0-rc1
      - v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider replacing release cut with say release tag

@clee2000 clee2000 changed the title Upload release cut source code to s3 Upload release tag source code to s3 Jun 26, 2024
@clee2000 clee2000 temporarily deployed to sourcecode-upload June 26, 2024 16:15 — with GitHub Actions Inactive
@clee2000
Copy link
Contributor Author

@pytorchbot merge -f "no trunk needed"

@pytorch pytorch deleted a comment from pytorch-bot bot Jun 26, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@clee2000
Copy link
Contributor Author

@pytorchbot cherry-pick --help

Copy link

pytorch-bot bot commented Jun 26, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: the following arguments are required: --onto, -c/--classification

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@clee2000
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/2.4 -c release

pytorchbot pushed a commit that referenced this pull request Jun 26, 2024
Upload tarball containing source code to s3 for release tags

Can be found here https://us-east-1.console.aws.amazon.com/s3/buckets/pytorch?region=us-east-1&bucketType=general&prefix=source_code/test/&showversions=false

D58695048 for adding permissions to allow uploading to the s3 folder
Pull Request resolved: #128842
Approved by: https://github.com/atalman, https://github.com/malfet

(cherry picked from commit 795db80)
@pytorchbot
Copy link
Collaborator

Cherry picking #128842

The cherry pick PR is at #129600 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

atalman pushed a commit that referenced this pull request Jun 27, 2024
Upload release tag source code to s3 (#128842)

Upload tarball containing source code to s3 for release tags

Can be found here https://us-east-1.console.aws.amazon.com/s3/buckets/pytorch?region=us-east-1&bucketType=general&prefix=source_code/test/&showversions=false

D58695048 for adding permissions to allow uploading to the s3 folder
Pull Request resolved: #128842
Approved by: https://github.com/atalman, https://github.com/malfet

(cherry picked from commit 795db80)

Co-authored-by: Catherine Lee <[email protected]>
@github-actions github-actions bot deleted the csl/upload_release_artifacts branch July 27, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants