Mac osx support #96
Mac osx support #96
Conversation
abhiramm7
commented
May 27, 2017
abhiramm7
commented
- Updated tests for to look for .so and .dll based on platform
- Added support for macos
- Updated Readme.rst
There was a problem hiding this comment.
Please Also update the setup.py file:
https://github.com/OpenWaterAnalytics/pyswmm/blob/master/setup.py#L57
and
https://github.com/OpenWaterAnalytics/pyswmm/blob/master/setup.py#L64
|
@goanpeca, Can you help with TravisCI for these changes? |
|
@abhiramm7, is there a smaller open-storm logo we can reference? |
|
@abhiramm7, I am going to turn travis on for pyswmm. Please update the |
setup.py
Outdated
| package_data={'': ['lib/windows/swmm5.dll', 'LICENSE.txt', 'AUTHORS']}, | ||
| include_package_data=True, | ||
| license="BSD2 License", | ||
| keywords="swmm5, swmm, hydraulics, hydrology, modeling, collection system", | ||
| classifiers=[ | ||
| "Topic :: Scientific/Engineering", | ||
| "Topic :: Documentation :: Sphinx", | ||
| "Operating System :: Microsoft :: Windows", | ||
| "Operating System :: Microsoft :: Windows, Apple :: macOS", |
There was a problem hiding this comment.
look up python classifiers:
https://docs.python.org/3/distutils/setupscript.html#additional-meta-data
setup.py
Outdated
| @@ -54,14 +54,16 @@ def get_description(): | |||
| author_email='[email protected]', | |||
| install_requires=REQUIREMENTS, | |||
| packages=find_packages(exclude=['contrib', 'docs', 'tests*']), | |||
| package_data={'': ['lib/windows/swmm5.dll', 'lib/macos/swmm5.so' , | |||
There was a problem hiding this comment.
maybe Github is not showing this diff correct, but is package_data being overwritten?
There was a problem hiding this comment.
@abhiramm7, it looks like package_data is being overwritten. add it into the list
pyswmm/swmm5.py
Outdated
| @@ -501,8 +504,8 @@ def getSimUnit(self, unittype): | |||
| >>> swmm_model.swmm_close() | |||
| """ | |||
| value = ctypes.c_int() | |||
| errcode = self.SWMMlibobj.swmm_getSimulationUnit(unittype, | |||
| ctypes.byref(value)) | |||
| errcode = self.SWMMlibobj.swmm_getSimulationUnit( | |||
There was a problem hiding this comment.
I would "un" line break these and get ciocheck running. These should all be solved with that
There was a problem hiding this comment.
Will do, i'll get it running
|
Travis file, not appveyor |
|
My bad ! |
|
One we get this working, we'll squash all these bad commits. |
|
@abhiramm7 you can also wait until Gonzalo is available. He's got lots of experience with Travis |
|
I think i found the error with travis, the dependencies were not loaded. I'll give it an other try. @bemcdonnell |
