added Simulation.percent_complete property and fixed function name #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goanpeca
reviewed
May 8, 2017
pyswmm/simulation.py
Outdated
| """ | ||
| dt = self.current_time - self.start_time | ||
| total_time = self.end_time - self.start_time | ||
| return dt.total_seconds() / total_time.total_seconds() |
There was a problem hiding this comment.
Are these values ints or floats? cause we might get undesired integer division. Maybe
dt.total_seconds()*1.0 / total_time.total_seconds()
To guarantee they are always floats? (Py2/Py3 gotchas)
There was a problem hiding this comment.
How about float(dt.total_seconds()) / total_time.total_seconds()?
bemcdonnell
commented
May 8, 2017
pyswmm/swmm5.py
Outdated
| @@ -24,6 +22,8 @@ | |||
|
|
|||
| # Local imports | |||
| from pyswmm.lib import DLL_SELECTION | |||
| import ctypes | |||
There was a problem hiding this comment.
@goanpeca, ciocheck seems to be moving this... Setting issue?
There was a problem hiding this comment.
add ctypes to known_standard_library: ctypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #88