Implement swmm-stride using c-code #481
Conversation
karosc
force-pushed
the
dev_swmm_stride
branch
from
b1f0d9e
to
548309b
Compare
|
@karosc is this good to go for review? I just looked at it and and keen to approve it. It is great work. PYSWMM-2.x here we go! I have a few changes that I am looking to make to the LID module and the OUT reader that will break some things... I'm hoping to get them through into pyswmm-2 before we make the release |
|
@bemcdonnell, from my point of view our next release will be 2.0. We can add to develop until we get there. |
|
@karosc are we still using flake8 to lint the code? |
There was a problem hiding this comment.
@karosc I think this is good. I'm just thinking the code needs to be linted with flake8. It looks like there are a few function args without spaces between the arguments
|
@karosc Again, fantastic work. I am going to make this merge into develop-v2.x branch. |
Closes #500
This PR makes the default
PySWMM.swmm_stride()method reference the c-code inswmm.toolkit.solver.swmm_stride()However, if a user is using swmm_toolkit < 0.15.0, the old python implementation of swmm_stride is monkey patched into the PySWMM class, keeping this version of pyswmm backwards compatible with older versions of
swmm.toolkit