Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sphinx documentation to gh pages #400

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Conversation

karosc
Copy link
Member

@karosc karosc commented Jan 26, 2023

  • new workflow for publish docs to gh-pages
    • docs are built whenever there is a push or PR event regardless of branch (to keep tabs on docs stability during development)
    • docs are only published when there is a push in to master or a merged PR into master. Makes deployed docs representative of current release since we should only push/merge to master right before a release.
  • separate doc dependencies into separate file
  • add caching to gh workflows

- new workflow for publish docs to gh-pages
- separate doc dependencies into separate file
- add caching to gh workflows
@bemcdonnell
Copy link
Member

@karosc i am trying to figure out if we need to push the orphan branch gh-pages to the repo right now. Do you need me to do anything aside from approve this PR?

@karosc
Copy link
Member Author

karosc commented Jan 26, 2023

@bemcdonnell, we do not need to publish an orphan branch now. After we push a new tag, the gh-pages branch should just auto publish. We then we need to change a repository setting to tell github to serve pages from that branch, after we do that, we shouldn't need to do anything manually again. New docs will auto deploy every time we push an new version tag.

@karosc
Copy link
Member Author

karosc commented Jan 26, 2023

@bemcdonnell, I'm not sure if you want to work on setting up a custom domain now or at a later date:

github.com/peaceiris/actions-gh-pages#%EF%B8%8F-add-cname-file-cname

docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site

docs.pyswmm.org would be nice 😄

@bemcdonnell
Copy link
Member

@karosc i know exactly where to go to get pyswmm docs served on gh-pages. I can do that shortly. As for the subdomain, I am using godaddy for pyswmm so I can add the subdomain once we have the link up

@karosc karosc merged commit c9f8d04 into pyswmm:develop Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants