Expand GitHub workflow #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add multi-platform unit testing (replace appveyor) - update deprecated actions
|
@karosc would you like me to deactivate appveyor? |
|
I think I captured the scope of appveyor in this PR with GH Workflow and thus appveyor can be deactivated to get the build to pass. |
|
@karosc if you push some trivial change to this PR, I have removed appveyor from the integrations list. It will pass as a greenlight when you do that. |
bemcdonnell
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multi-platform testing to github actions.
This feature will ensure that pyswmm can be installed on all typical platforms. Since pyswmm is dependent on compiled swmm-toolkit code, if the swmm-toolkit release is failing, then this pyswmm workflow will also fail.
Moving testing to github actions also deprecates appveyor.