Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminating VCOMP DLL Not Found on Windows #191

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

bemcdonnell
Copy link
Member

Closes #186
Closes #153

Fixes a longstanding WINDOWS issue:

When opening SWMM some users experienced a windows os exception. SWMM could not resolve any path to Open MP. This PR contains the OpenMP binary and adds the directory path to the system path variable.

@bemcdonnell
Copy link
Member Author

@jennwuu, I tested this on the windows server and it seems to work. @kmmacro, I think you were having this same issue a few weeks ago. Can you try it out too?

I think we should reach out to those who raised the issues and see if this bug fix solves it for them too.

@katmratliff
Copy link
Contributor

I tested this on my Windows 10 machine and it works (although I don't recall having this issue in the past).

Copy link
Member

@aerispaha aerispaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my Windows 10 machine ✔️

@bemcdonnell bemcdonnell merged commit 4c91597 into pyswmm:master Jul 11, 2019
@bemcdonnell bemcdonnell deleted the fix_vomp_dep branch July 11, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSError: [WinError 193] %1 is not a valid Win32 application Pyswmm on Windows, OSError [WinError 126]
4 participants