-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for contributing code #606
Docs for contributing code #606
Conversation
…ntributing code to DoWhy Signed-off-by: Michael Marien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks @MichaelMarien . I've added some initial comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, but otherwise LGTM
…iz info Signed-off-by: Michael Marien <[email protected]>
Signed-off-by: Michael Marien <[email protected]>
…ration Signed-off-by: Michael Marien <[email protected]>
Signed-off-by: Michael Marien <[email protected]>
Signed-off-by: Michael Marien <[email protected]>
Signed-off-by: Michael Marien <[email protected]>
I believe I fixed all open requests, let me know if something is still missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The edits looks great. Approving.
Overall, this is a fantastic resource for developers. Thank you @MichaelMarien for adding this.
@all-contributors please add @MichaelMarien for doc. |
I've put up a pull request to add @MichaelMarien! 🎉 |
Added documentation for getting started with local development and contributing code to DoWhy.
Fixes #528
Open topics I propose to take up later in different PR's:
Topics not touched due to unclarity on my side
Signed-off-by: Michael Marien [email protected]