Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guide on how to pass the DCO check for new PRs #539

Open
amit-sharma opened this issue Jul 15, 2022 · 2 comments
Open

Add guide on how to pass the DCO check for new PRs #539

amit-sharma opened this issue Jul 15, 2022 · 2 comments
Labels
docs Documentation-related good first issue Good for newcomers

Comments

@amit-sharma
Copy link
Member

Many contributors are facing problems passing the DCO check.

will be good to add instructions for specifying DCO as written in this Github guide for one of the PRs.

This content can be added as a new DCO.rst file under docs/source/contributing
@amit-sharma amit-sharma added the docs Documentation-related label Jul 15, 2022
@petergtz petergtz changed the title [docs] Add guide on how to pass the DCO check for new PRs Add guide on how to pass the DCO check for new PRs Aug 2, 2022
@emrekiciman emrekiciman added the good first issue Good for newcomers label Aug 15, 2022
@emrekiciman
Copy link
Member

see PR #606

@greeshmasmenon
Copy link

Should this be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation-related good first issue Good for newcomers
Projects
PyWhy Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amit-sharma @emrekiciman @greeshmasmenon